From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5233: don't require root for some tape operations
Date: Tue, 12 Nov 2024 21:15:12 +0100 [thread overview]
Message-ID: <68d6639e-a27d-4198-be2e-6a423a78581f@proxmox.com> (raw)
In-Reply-To: <20240910070818.268267-1-d.csapak@proxmox.com>
Am 10.09.24 um 09:08 schrieb Dominik Csapak:
> instead, require 'Tape.Write' on '/tape' path.
> This makes it possible for a TapeAdmin or TapeOperator to
> format/remove/vault tapes, instead of just root@pam.
>
> I opted for the path '/tape' since we don't have a dedicated acl
> structure for single tapes, just '/tape/pool' (which does not apply
> since not all tapes have to have a pool), '/tape/device' (which is
> intended for drives/changers) and '/tape/jobs' (which is for jobs only).
>
> Alternatively we could invent a new scheme for tape media, e.g.
> '/tape/media' for this.
the path is fine, but why Tape.Write over Tape.Modify?
> Tape.Modify
> Tape.Modify allows a user to modify the configuration of tape drives, changers and backups.
vs
> Tape.Write
> Tape.Write allows a user to write to a tape media.
The former might be a better fit here as these calls alter not only the tape
content, or?
Noticed because Hannes' recent patch already switched the move-tape one to
Tape.Modify,
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-12 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 7:08 Dominik Csapak
2024-11-12 20:15 ` Thomas Lamprecht [this message]
2024-11-13 7:42 ` Dominik Csapak
2024-11-13 8:25 ` Thomas Lamprecht
2024-11-13 11:38 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d6639e-a27d-4198-be2e-6a423a78581f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox