From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 4A3691FF15C
	for <inbox@lore.proxmox.com>; Fri,  4 Apr 2025 17:57:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 6FD373669F;
	Fri,  4 Apr 2025 17:57:02 +0200 (CEST)
Message-ID: <67b05d9d-3c5f-4d1d-9582-80cadc9370c8@proxmox.com>
Date: Fri, 4 Apr 2025 17:56:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Max Carrara <m.carrara@proxmox.com>
References: <20250321080254.68931-1-c.ebner@proxmox.com>
 <D8XYVB5LZNPU.2RLYD2N5TSG9N@proxmox.com>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <D8XYVB5LZNPU.2RLYD2N5TSG9N@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.030 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH v8 proxmox proxmox-backup 0/9] fix #5982:
 check atime update is honored
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

Thanks for your throw review an for catching the permission issue! I 
will have a closer look at this over the weekend and send a new version 
(as I have to leave now). But this should be fixed rather easily by 
either setting the ownership of the chunk after insert in the 
corresponding code path or add a dedicated helper just for insertion of 
the marker chunk, which takes care of that.

And to quickly answer your question regarding noatime: yes, the 
utimensat call bypasses all of these fs options, it is therefore rather 
neat for our use case. But there are some filesystems out there (as of 
reports in the community forum and enterprise repository) which do not 
handle the atime updates as expected. Therefore the path. And no, 
unfortunately I also have no filesystem which does not honor this for 
testing.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel