From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id DB7E593F5F
 for <pbs-devel@lists.proxmox.com>; Wed, 10 Apr 2024 12:41:59 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id BAACBBE72
 for <pbs-devel@lists.proxmox.com>; Wed, 10 Apr 2024 12:41:29 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Wed, 10 Apr 2024 12:41:28 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7626E43C35
 for <pbs-devel@lists.proxmox.com>; Wed, 10 Apr 2024 12:41:28 +0200 (CEST)
Date: Wed, 10 Apr 2024 12:41:27 +0200 (CEST)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>,
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <678963702.5746.1712745687780@webmail.proxmox.com>
In-Reply-To: <D0GBP9WGALT3.16K122WDO8LYU@proxmox.com>
References: <20240409110012.166472-1-h.laimer@proxmox.com>
 <20240409110012.166472-7-h.laimer@proxmox.com>
 <1766926142.5540.1712739735533@webmail.proxmox.com>
 <D0GBP9WGALT3.16K122WDO8LYU@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev61
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.345 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 06/24] api2: admin: add
 (un)mount endpoint for removable datastores
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2024 10:41:59 -0000


> On 10.4.2024 11:08 CEST Hannes Laimer <h.laimer@proxmox.com> wrote:
> 
>  
> On Wed Apr 10, 2024 at 11:02 AM CEST, Dietmar Maurer wrote:
> > comments inline
> >
> > > On 9.4.2024 12:59 CEST Hannes Laimer <h.laimer@proxmox.com> wrote:
> > > 
> > >  

> > > +pub fn do_mount_device(
> >
> > why is this public?
> >
> 
> we need it on datastore creation which is in `/config/`

I think "pub(crate)" would be good enough?