From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 87CF4B85D for <pbs-devel@lists.proxmox.com>; Thu, 7 Apr 2022 14:06:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 794D5485D for <pbs-devel@lists.proxmox.com>; Thu, 7 Apr 2022 14:06:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 58D6B484F for <pbs-devel@lists.proxmox.com>; Thu, 7 Apr 2022 14:06:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 239C646188 for <pbs-devel@lists.proxmox.com>; Thu, 7 Apr 2022 14:06:02 +0200 (CEST) Message-ID: <66b44af7-4a22-a97e-41bf-4074360462a8@proxmox.com> Date: Thu, 7 Apr 2022 14:06:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20220328075419.1020418-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20220328075419.1020418-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-proxy.rs] Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v2 1/3] rest-server: cleanup_old_tasks: improve error handling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 07 Apr 2022 12:06:09 -0000 On 28.03.22 09:54, Dominik Csapak wrote: > by not bubbling up most errors, and continuing on. this avoids that we > stop cleaning up because e.g. one directory was missing. > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > changes from v1: > * ignore only ENOENT error for task log archive dirs, > log all other errors > * use task_log instead of log::errors, this way the task will end on a > 'WARNINGS' and the user sees that something was wrong with it > this also has the advantage that the errors really go into the task > log instead of the syslog > * improve error messages > > proxmox-rest-server/src/worker_task.rs | 38 ++++++++++++++++++++------ > src/bin/proxmox-backup-proxy.rs | 2 +- > 2 files changed, 30 insertions(+), 10 deletions(-) > > applied, with the merge conflict from a recent rustfmt resolved and the followup discussed off-list to fix the off-by-one file deletion the series had, thanks!