From: Christian Ebner <c.ebner@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup] Revert "fix #5710: api: backup: stat known chunks on backup finish"
Date: Mon, 13 Jan 2025 14:10:39 +0100 [thread overview]
Message-ID: <6693e590-1026-4b7c-97ff-2f9b95deaeee@proxmox.com> (raw)
In-Reply-To: <1736772071.mcbrxnbmft.astroid@yuna.none>
On 1/13/25 13:48, Fabian Grünbichler wrote:
> On January 13, 2025 11:47 am, Christian Ebner wrote:
>> On 1/13/25 11:36, Fabian Grünbichler wrote:
>>> we should probably spec out some potential replacement approaches?
>>
>> Agreed, but I would nevertheless argue for reverting this for the time
>> being: a new approach will not use the same logic. What do you suggest?
>
> yes, the revert is already applied now :)
>
> we discussed some potential approaches internally a few weeks back, IIRC
> some potential mechanisms:
>
> A) actively mark all snapshots referencing a certain chunk as corrupt
> when we detect the chunk corruption probably needs to be combined with
> some sort of reverse-map from chunk to list of snapshots to scale.
>
>
> B) mark all snapshots in the chain after the corruption as potentially
> corrupt (new state) and incorporate that into the reverify logic to
> detect other snapshots with a high likelihood of being affected quickly
>
> C) notify active backup writers of chunks or snapshots being marked as
> corrupt. chunks can be cross-referenced at the end with re-used chunks,
> snapshots could trigger stat logic similar to the one we just reverted
> in case the snapshot is in the same group as the backup writer
>
> D) ..?
Thanks!
I did update the issue in the bugtracker accordingly and linked to your
suggestions for reference, will have a closer look at how to approach
this once again.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-01-13 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 7:52 [pbs-devel] " Christian Ebner
2025-01-07 8:36 ` Christian Ebner
2025-01-09 10:29 ` Mark Schouten
2025-01-13 10:36 ` [pbs-devel] applied: " Fabian Grünbichler
2025-01-13 10:47 ` Christian Ebner
2025-01-13 12:48 ` Fabian Grünbichler
2025-01-13 13:10 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6693e590-1026-4b7c-97ff-2f9b95deaeee@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox