From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 45BC51FF13C for ; Thu, 05 Mar 2026 10:20:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC5F31F3D6; Thu, 5 Mar 2026 10:21:40 +0100 (CET) Message-ID: <664835ff-a778-4a27-8f4b-69ea8ea5d516@proxmox.com> Date: Thu, 5 Mar 2026 10:21:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: superseded: [PATCH proxmox-backup] datastore: don't skip empty namespaces on s3 refresh To: pbs-devel@lists.proxmox.com References: <20260304103938.42167-1-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260304103938.42167-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772702471094 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7XURA6PVQC77DQVOUNLVCWAAKS7FCYYY X-Message-ID-Hash: 7XURA6PVQC77DQVOUNLVCWAAKS7FCYYY X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: superseded-by: https://lore.proxmox.com/pbs-devel/20260305092032.29058-1-h.laimer@proxmox.com/T/#u On 2026-03-04 11:39, Hannes Laimer wrote: > Without this empty namespaces present on s3 won't be visible locally. > > Signed-off-by: Hannes Laimer > --- > pbs-datastore/src/datastore.rs | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs > index 7ad3d917..4749319a 100644 > --- a/pbs-datastore/src/datastore.rs > +++ b/pbs-datastore/src/datastore.rs > @@ -2535,6 +2535,15 @@ impl DataStore { > format!("failed to strip store context prefix {store_prefix} for {object_key}") > })?; > if object_path.ends_with(NAMESPACE_MARKER_FILENAME) { > + // Ensure the marker's parent directory exists so the namespace is visible locally > + let ns_dir = tmp_base.join(object_path); > + if let Some(parent) = ns_dir.parent() { > + proxmox_sys::fs::create_path( > + parent, > + Some(dir_create_options), > + Some(dir_create_options), > + )?; > + } > continue; > } >