From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1657191FFC for ; Thu, 9 Feb 2023 17:59:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F385C27760 for ; Thu, 9 Feb 2023 17:59:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 9 Feb 2023 17:59:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6E7D0465DC for ; Thu, 9 Feb 2023 17:59:46 +0100 (CET) Message-ID: <6632febf-c30a-8796-e941-cd5f2d9e471a@proxmox.com> Date: Thu, 9 Feb 2023 17:59:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Thunderbird/105.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Stefan Sterz , Wolfgang Bumiller References: <20230209114139.501580-1-s.sterz@proxmox.com> <20230209141654.5r2dkru47uscqbzr@fwblub> From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.523 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.148 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4521: api/tasks: replace upid as filename for task log downloads X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2023 16:59:48 -0000 On 09/02/2023 15:18, Stefan Sterz wrote: >> It contains colons which seem to be turned to spaces by my browser. >> Colons in http headers are a bit weird? Colons are fine in HTTP header, they don't add any ambiguity on it's own as header key's are the part from start of line to the _first_ colon. The RFCs (7231 or the updated 9110) allow all printable ASCII chars (0x21 to 0x7E). In fact, if I use `curl -OJ`, telling it to use the content-disposition header, it does the right thing and safes the file correctly, preserving colons. FWICT it's really just due to Windows limitations w.r.t. file naming that the browser seemingly spread to all platforms (possibly to avoid that Linux user passing files to Windows users breaks) - maybe open a bug there? x) >> Maybe we should just strip them out or replace them with underscores or >> something? > underscores sound good to me. > meh... if, we'd need to adapt PVE again, there I already applied this.