From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9EE991FF09B for ; Mon, 14 Sep 2026 13:47:46 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5AA78214EF; Mon, 14 Sep 2026 13:47:46 +0200 (CEST) Message-ID: <661d7d35-e5b5-426e-ab78-b9f951285437@proxmox.com> Date: Mon, 14 Sep 2026 13:47:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox{,-backup} 0/9] support index readers on larger page sizes To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260731142430.289893-1-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260731142430.289893-1-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789386441745 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.664 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4R6PAYOVCVCQTFBGWGFCKNMDDXH2GMFU X-Message-ID-Hash: 4R6PAYOVCVCQTFBGWGFCKNMDDXH2GMFU X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/31/26 4:25 PM, Robert Obkircher wrote: > Fix `proxmox-backup-client restore` and pbs in general on systems with > a larger page size. > > Also ensure that `proxmox-backup-debug inspect` displays a consistent > size for fixed and dynamic index files, and include the total backup > size in the output. > > proxmox: > > Robert Obkircher (1): > proxmox-sys: add len and as_non_null method to Mmap > > proxmox-sys/src/mmap.rs | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > > proxmox-backup: > > Robert Obkircher (8): > datastore: limit scope of mutable reference in FixedIndexWriter::close > datastore: add tests for fixed and dynamic index reader > datastore: fix inconsistent implementation of index_size method > bin: debug: print referenced backup size for index files > datastore: check that index files are regular files > datastore: simplify FixedIndexReader::chunk_info > datastore: always access dynamic index reader slice through method > fix #7244: datastore: always mmap index files from offset 0 > > pbs-datastore/src/dynamic_index.rs | 154 ++++++++++++------- > pbs-datastore/src/fixed_index.rs | 195 +++++++++++++----------- > pbs-datastore/src/index.rs | 5 + > pbs-datastore/src/index_mmap.rs | 171 +++++++++++++++++++++ > pbs-datastore/src/lib.rs | 1 + > src/bin/proxmox_backup_debug/inspect.rs | 4 + > 6 files changed, 387 insertions(+), 143 deletions(-) > create mode 100644 pbs-datastore/src/index_mmap.rs > > > Summary over all repositories: > 7 files changed, 402 insertions(+), 143 deletions(-) Verified restores via proxmox-backup-client, sync jobs as well as build for proxmox-backukp-qemu and pbs-restore are unaffected with patches applied: Reviewed-by: Christian Ebner Tested-by: Christian Ebner