From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CADE71FF15E for ; Fri, 18 Oct 2024 09:37:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BF84C1C8CE; Fri, 18 Oct 2024 09:37:39 +0200 (CEST) Message-ID: <65709388-789e-4531-acfa-38eefed6be78@proxmox.com> Date: Fri, 18 Oct 2024 09:37:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20241011093355.218198-1-c.ebner@proxmox.com> <20241011093355.218198-2-c.ebner@proxmox.com> <3d6ae324-7aab-4547-87f4-b63f632c0b3e@proxmox.com> <537595b3-00bc-4663-907f-1ea1e7a10927@proxmox.com> <918a092b-703c-485d-9ca1-c48a9c3339b4@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <918a092b-703c-485d-9ca1-c48a9c3339b4@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] applied: [PATCH v3 proxmox-backup] partial fix #5560: client: periodically show backup progress X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 10/18/24 09:20, Thomas Lamprecht wrote: > Am 17/10/2024 um 17:53 schrieb Christian Ebner: >> On 10/17/24 17:02, Thomas Lamprecht wrote: >>> applied, thanks! With some opinionated line-reduction as follow-up (opinionated >>> because it was OK as is too, and I could have noticed that on the previous >>> review, sorry...) >>> >>> Did not think it through at all, but maybe it makes sense to add the uploaded >>> size also to the upload stats. >> >> For now I do not see much benefit for this, as after consuming the full >> upload stream there are no more chunks queued for upload, so the >> counters already present in `UploadStats` contain the same information. >> >> And this information is already shown to the user at the end of the >> upload as, e.g.: >> ``` >> had to backup 1.66 GiB of 285.242 GiB (compressed 1.274 GiB) in 58.52 s >> (average 29.053 MiB/s) >> ``` > > Ack, thanks for clearing this up to me. One thing still came to mind yesterday though: Progress logging is now enabled unconditionally, and as is it is not possible to disable it or configure the interval. So I plan to send a patch to make the progress log output opt-in, and make the interval configurable within a meaningful value range (maybe within 0s to 3600s?). Something like: ``` proxmox-backup-client backup root.pxar:/ --progress-log-interval=10 ``` And disable progress log output for a value of 0 or the optional parameter is not given. That would also allow to more flexibly control the behavior when being invoked by vzdump. What are your opinions on that? _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel