From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5C68F1FF16C for ; Tue, 17 Sep 2024 09:23:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6CAE7119CE; Tue, 17 Sep 2024 09:23:06 +0200 (CEST) Message-ID: <6567827a-18ec-4170-a216-135b77fdf3a3@proxmox.com> Date: Tue, 17 Sep 2024 09:23:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20240913135944.317298-1-c.ebner@proxmox.com> <20240916101740.4nfm6pjhiapppno5@luna.proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20240916101740.4nfm6pjhiapppno5@luna.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC proxmox-backup] fix #5710: api: backup: stat known chunks during backup X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 9/16/24 12:17, Gabriel Goller wrote: > On 13.09.2024 15:59, Christian Ebner wrote: >> In order to reduce the impact, stat the list of known chunks twice >> during backup: >> - during registration of a known chunk >> - when finishing the backup >> >> The first stat is to early on detect missing chunks, the latter >> assures that all (known and newly registered) chunks are present on >> the datastore after the backup run. >> >> If a missing chunk is detected, the backup run itself will fail and >> the previous backup snapshots verify state is set to failed. >> This prevents the same snapshot from being reused by another, >> subsequent backup job. > > I wonder if we need the first option. We could only `stat` the chunks at > the end of the backup to improve performance. The first stat is intended to early detect and fail the backup run on missing chunks, but you are right, to minimize the performance impact only the final stat when finishing the backup run is enough. Will drop the first check altogether in a new version of the patch. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel