From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D4159B8B9A for ; Mon, 11 Mar 2024 14:50:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B41449CB5 for ; Mon, 11 Mar 2024 14:50:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 11 Mar 2024 14:50:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 746E3488EF for ; Mon, 11 Mar 2024 14:50:24 +0100 (CET) Date: Mon, 11 Mar 2024 14:50:23 +0100 (CET) From: Christian Ebner To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= Message-ID: <655178535.10743.1710165023860@webmail.proxmox.com> In-Reply-To: <1710152828.1ncysi2oe3.astroid@yuna.none> References: <20240305092703.126906-1-c.ebner@proxmox.com> <20240305092703.126906-3-c.ebner@proxmox.com> <1710152828.1ncysi2oe3.astroid@yuna.none> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev59 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [RFC v2 pxar 02/36] encoder: add optional output writer for file payloads X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2024 13:50:55 -0000 On 3/11/24 14:21, Fabian Gr=C3=BCnbichler wrote: > On March 5, 2024 10:26 am, Christian Ebner wrote: >=20 > should we prevent/catch this being called multiple times? The attaching of the optional payload output being possible at any time and even multiple times is something Dietmar noticed as well. I will follow his suggestion here and add this as an optional parameter to the encoders `new` method, which will handle this better at the cost of breaking the API. Are there objections to that? >=20 >=20 > this part here and the read counter-part in the next commit basically > hard-code the format of this entry type, maybe that could be handled > nicer? e.g., construct a PayloadRef here, and let that implement the > conversion to/from data? >=20 > it is a pre-existing pattern here though ;) > Okay, will have a look on how to handle the serialization in a more generic way, especially since the `PayloadRef` struct will be used later in the decoder anyway (therefore already have that), so it might make sense to e.g. have a trait for all pxar entry types to that guarantees the serialization methods. Is that what you had in mind here? >=20 > nit: the two if-lets could be combined: >=20 > if let EncoderOutput::Owned(Some(output)) =3D &mut self.payload_output { > .. > } >=20 Forgot to `cargo clippy` these patches, which also suggests to combine these. Will be addressed in a followup version of the patches.