From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 92B7A694EF
 for <pbs-devel@lists.proxmox.com>; Wed, 24 Feb 2021 07:13:21 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 865942522E
 for <pbs-devel@lists.proxmox.com>; Wed, 24 Feb 2021 07:13:21 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 7A9EA2521E
 for <pbs-devel@lists.proxmox.com>; Wed, 24 Feb 2021 07:13:20 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 49FE841C3B
 for <pbs-devel@lists.proxmox.com>; Wed, 24 Feb 2021 07:13:20 +0100 (CET)
Date: Wed, 24 Feb 2021 07:13:18 +0100 (CET)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, 
 Thomas Lamprecht <t.lamprecht@proxmox.com>,
 Wolfgang Bumiller <w.bumiller@proxmox.com>
Message-ID: <654681787.11.1614147199226@webmail.proxmox.com>
In-Reply-To: <1644937938.10.1614108472151@webmail.proxmox.com>
References: <20210223145403.2126-1-d.csapak@proxmox.com>
 <1716330912.3668.1614097567040@webmail.proxmox.com>
 <16b17f26-ec37-fd9f-004d-2fd146a4d900@proxmox.com>
 <1644937938.10.1614108472151@webmail.proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.4-Rev18
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.116 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup]
 api2/config/tape_backup_job: fix duplicate id parameter
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 24 Feb 2021 06:13:21 -0000


> On 02/23/2021 8:27 PM Dietmar Maurer <dietmar@proxmox.com> wrote:
> 
>  
> Will fix this tomorrow - we need to set the #[fixed] attribute for id

Just saw that we already set the  #[updater(fixed)] attribute.

The docs say:

> Additionally the #[updater(fixed)] option is available to make it illegal 
> for an updater to modify a field (generating an error if it is set), 
> while still allowing it to be used to create a new object via the build_from() method.

So the Updater includes all "fixed" fields (which leads to the duplicate id problem).

I would prefer an Updater which simply omits fixed fields.

Can we change that?