From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3C5F41FF161 for ; Tue, 30 Jul 2024 12:42:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F42A3A194; Tue, 30 Jul 2024 12:42:11 +0200 (CEST) Message-ID: <641dcc20-871c-4ddd-809e-89dd0f1d8661@proxmox.com> Date: Tue, 30 Jul 2024 12:42:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20240715101602.274244-1-c.ebner@proxmox.com> <5be4c3d1-593f-4eec-b21b-33cb3afc9216@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <5be4c3d1-593f-4eec-b21b-33cb3afc9216@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC proxmox-backup 00/24] fix #3044: push datastore to remote X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/17/24 17:48, Thomas Lamprecht wrote: > > It might even make sense to evaluate using a different sync job section > type, and thus config, for these; not saying that's a must, but it myabe > could additionally help to avoid mistakes. Had a closer look at this: If I see correctly, this would imply to either create duplicate API endpoints for interacting with the config or pass an additional sync direction variant flag to the preexisting endpoints, in order to distinguish the section types and therefore sync job variants while keeping the same `SyncJobConfig`. The latter seems to be the more promising approach. So I will go for adding a new section type `sync-push` and add the `SyncDirection` parameters where required. This separates the sync job variants cleanly in the config, making it impossible to switch sync direction by simply deleting a line (switching over the config type can not happen as easily, therefore better protecting from accidental misconfiguration). _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel