From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DE9971FF16B for <inbox@lore.proxmox.com>; Thu, 20 Feb 2025 16:13:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2BBEB166AE; Thu, 20 Feb 2025 16:13:51 +0100 (CET) Message-ID: <640256fd-71fb-491a-94ec-eb80875e3eb5@proxmox.com> Date: Thu, 20 Feb 2025 16:13:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20250220151244.16524-1-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer <h.laimer@proxmox.com> In-Reply-To: <20250220151244.16524-1-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-firewall 1/2] fix: firewall: apply `nt_conntrack_allow_invalid` to all chains X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> ups, wrong list. sorry for the noise On 2/20/25 16:12, Hannes Laimer wrote: > ... on the guest table. There is no reason to not repect that option > on those two chains. These two were missed in the referenced commit. > > Fixes: 64dc344b ("firewall: apply `nt_conntrack_allow_invalid` option to guest table") > Signed-off-by: Hannes Laimer <h.laimer@proxmox.com> > --- > proxmox-firewall/resources/proxmox-firewall.nft | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/proxmox-firewall/resources/proxmox-firewall.nft b/proxmox-firewall/resources/proxmox-firewall.nft > index 2dd7c48..30f7b4f 100644 > --- a/proxmox-firewall/resources/proxmox-firewall.nft > +++ b/proxmox-firewall/resources/proxmox-firewall.nft > @@ -356,7 +356,7 @@ table bridge proxmox-firewall-guests { > } > > chain pre-vm-out { > - meta protocol != arp ct state vmap { established : accept, related : accept, invalid : drop } > + meta protocol != arp ct state vmap { established : accept, related : accept, invalid : jump invalid-conntrack } > } > > chain vm-out { > @@ -384,7 +384,7 @@ table bridge proxmox-firewall-guests { > > chain before-bridge { > meta protocol arp accept > - meta protocol != arp ct state vmap { established : accept, related : accept, invalid : drop } > + meta protocol != arp ct state vmap { established : accept, related : accept, invalid : jump invalid-conntrack } > } > > chain forward { _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel