From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8028674F04 for ; Fri, 4 Jun 2021 11:04:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7BED71ADA0 for ; Fri, 4 Jun 2021 11:04:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D5EBD1AD93 for ; Fri, 4 Jun 2021 11:04:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AC3A346706 for ; Fri, 4 Jun 2021 11:04:45 +0200 (CEST) Message-ID: <63ba7f7e-50aa-d9dd-abf3-6c192f2761e7@proxmox.com> Date: Fri, 4 Jun 2021 11:04:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20210604071625.4811-1-d.csapak@proxmox.com> <1622794517.ypqwqri9n2.astroid@nora.none> From: Thomas Lamprecht In-Reply-To: <1622794517.ypqwqri9n2.astroid@nora.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.316 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.603 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] client/pull: log snapshots that are skipped because of time X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2021 09:04:51 -0000 On 04.06.21 10:21, Fabian Gr=C3=BCnbichler wrote: > On June 4, 2021 9:16 am, Dominik Csapak wrote: >> @@ -495,6 +496,11 @@ pub async fn pull_group( >> =20 >> if let Some(last_sync_time) =3D last_sync { >> if last_sync_time > backup_time { >> + task_log!( >> + worker, >> + "skipping snapshot {} - older than last sync", >> + snapshot >> + ); >=20 > adding this would mean that sync logs would grow and grow and grow over= =20 > time.. >=20 > maybe a single: >=20 > skipped 32 remote snapshots (2021-MM-DDTHH:MM::SSZ..2021-MM-DDTHH:MM::S= SZ) older than newest local snapshot. >=20 > it would mean only adding a single line to the output, but contains=20 > almost all the information? If we want to just log that for now that this is def. the more sensible a= pproach, task logs should be always as readable, where less to read without losing= any, or at least not much, information is always nice, so: +1