From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4A28E74C44 for ; Mon, 11 Oct 2021 14:58:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 40BFF20ECE for ; Mon, 11 Oct 2021 14:57:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 38ECA20EC0 for ; Mon, 11 Oct 2021 14:57:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 178CB45D03 for ; Mon, 11 Oct 2021 14:57:39 +0200 (CEST) Message-ID: <637c31e5-7c5b-065a-811d-ccd54eeaaa1b@proxmox.com> Date: Mon, 11 Oct 2021 14:57:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20211011121432.1006944-1-d.csapak@proxmox.com> <20211011121432.1006944-2-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211011121432.1006944-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.207 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup v2 2/2] backup-proxy: fix api log reopen send_command calls X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2021 12:58:10 -0000 On 11.10.21 14:14, Dominik Csapak wrote: > if we give a string to send_command, it gets to the receiving end as a > string again (not an object), and the command fails with: > > 'unable to parse parameters (expected json object)' > > Instead, use send_raw_command which expects the string. Also refactor > the identical command strings. > > Fixes: commit 45b8a0327f21f048bb4384bafc292954358b5651 > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * include fixed commit in commit message > * use send_raw_command with the original strings > > src/bin/proxmox-backup-proxy.rs | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > applied this one for now but dropped the factoring out of the command, not really worth it IMO and I prefer to keep (initial) change noise small for those things, thanks! Also did a semantic backport to the stable-1 branch, cherry-picking is rather out of the window with that big bunch of restructuring that happend in the last weeks/months.