From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 06194AF21 for ; Fri, 8 Sep 2023 15:07:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DE4EA12435 for ; Fri, 8 Sep 2023 15:07:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 8 Sep 2023 15:07:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B8C534326C for ; Fri, 8 Sep 2023 15:07:17 +0200 (CEST) Message-ID: <6248308c-0fa6-34c4-0845-e0e4523a3f08@proxmox.com> Date: Fri, 8 Sep 2023 15:07:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20230828084408.36519-1-g.goller@proxmox.com> <528d4cc8-c361-412a-ad22-497118bbd550@proxmox.com> From: Gabriel Goller In-Reply-To: <528d4cc8-c361-412a-ad22-497118bbd550@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.321 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.473 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox] fix #4162: sys: added `auto-submitted` header to email body X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2023 13:07:19 -0000 Sent a new patch version. On 9/7/23 17:42, Thomas Lamprecht wrote: > On 28/08/2023 10:44, Gabriel Goller wrote: >> `Auto-Submitted` is defined in the rfc 5436 [1] and describes how >> an automatic response (f.e. ooo replies, etc.) should behave on the >> emails. When using `Auto-Submitted: auto-generated` (or any value >> other than `none`) automatic replies won't be triggered. >> >> [1]: https://www.rfc-editor.org/rfc/rfc3834.html >> >> Signed-off-by: Gabriel Goller >> --- >> proxmox-sys/src/email.rs | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/proxmox-sys/src/email.rs b/proxmox-sys/src/email.rs >> index da910d4..9f53718 100644 >> --- a/proxmox-sys/src/email.rs >> +++ b/proxmox-sys/src/email.rs >> @@ -81,6 +81,7 @@ pub fn sendmail( > Please add the fact that this is always for auto-generated mails to the > doc comment, so that anybody that wants to use this for something where > a human actually writes/sends the mail is aware of this behavior. > >> } >> if let Some(html) = html { > why only add this to mails that include HTML, but not pure plain text ones? > Didn't see anything in the RFC that would indicate it should be done this > way, or did I overlook that part? > >> body.push_str("Content-Type: text/html;\n"); >> + body.push_str("Auto-Submitted: auto-generated;\n"); >> body.push_str("\tcharset=\"UTF-8\"\n"); >> body.push_str("Content-Transfer-Encoding: 8bit\n"); >> body.push('\n');