From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 123326AC76 for ; Wed, 17 Feb 2021 08:58:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 08CB91F165 for ; Wed, 17 Feb 2021 08:58:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9805C1F158 for ; Wed, 17 Feb 2021 08:58:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 60BDB4485C for ; Wed, 17 Feb 2021 08:58:25 +0100 (CET) To: Dietmar Maurer , Proxmox Backup Server development discussion References: <20210216170710.31767-1-s.reiter@proxmox.com> <20210216170710.31767-10-s.reiter@proxmox.com> <1667517314.3028.1613544553823@webmail.proxmox.com> From: Stefan Reiter Message-ID: <62011626-da51-ed12-d405-4274eb8ab71d@proxmox.com> Date: Wed, 17 Feb 2021 08:58:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1667517314.3028.1613544553823@webmail.proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, proxmox-backup-client.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup 09/22] client: extract common functions to proxmox_client_tools module X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 07:58:56 -0000 On 17/02/2021 07:49, Dietmar Maurer wrote: > I thought we can put all client related code into src/client/ > > So why starting another lib inside src/bin/proxmox_client_tools/? > Why was (part of) it initially in src/bin/proxmox_backup_client then and not src/client/ ? I thought it was to seperate the "binary-specific" client code from more generic client code (such as used in pull or the QEMU library as well). Wouldn't mind putting it in src/client either though. > >> On 02/16/2021 6:06 PM Stefan Reiter wrote: >> >> >> ...including common schemata, connect(), extract_*() and completion >> functions. >> >> For later use with proxmox-file-restore binary. >> >> Signed-off-by: Stefan Reiter >> --- >> src/bin/proxmox-backup-client.rs | 361 +-------------------------- >> src/bin/proxmox_client_tools/mod.rs | 366 ++++++++++++++++++++++++++++