From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8C94F93DBD for ; Wed, 10 Apr 2024 09:11:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 666CB8F68 for ; Wed, 10 Apr 2024 09:11:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 10 Apr 2024 09:11:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A24244343F for ; Wed, 10 Apr 2024 09:11:17 +0200 (CEST) Date: Wed, 10 Apr 2024 09:11:16 +0200 (CEST) From: Christian Ebner To: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= , pbs-devel@lists.proxmox.com Message-ID: <62007162.5314.1712733076980@webmail.proxmox.com> In-Reply-To: <1712731289.pe9iwgvz9y.astroid@yuna.none> References: <20240328123707.336951-1-c.ebner@proxmox.com> <20240328123707.336951-48-c.ebner@proxmox.com> <171230603494.1926770.11920216027784905682@yuna.proxmox.com> <1712731289.pe9iwgvz9y.astroid@yuna.none> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev61 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 47/58] client: pxar: add look-ahead caching X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2024 07:11:48 -0000 > On 10.04.2024 09:03 CEST Fabian Gr=C3=BCnbichler wrote: >=20 >=20 > yes, sorry for not phrasing that more explicitly - I just meant to say > that we mishandle those wrong "Suggestions" here (because "CheckNext" is > suggested too often, we then proceed with re-encoding if the next file > is not re-usable. there also is the second issue about re-usable file > sequences crossing chunk boundaries and padding that can cause the > suggestion to take a wrong turn). >=20 > not like "this code here is broken", but "it does the wrong thing based > on wrong information" ;) the fix is (most likely) in the suggestion > part, not in the handling part here.. but depending on the solution, it > might also be necessary to adapt something here :) Okay, thanks for the clarification!