From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7334D1FF140 for ; Fri, 27 Mar 2026 11:04:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B006C26F1; Fri, 27 Mar 2026 11:05:16 +0100 (CET) Message-ID: <5e16343c-c0fc-4e46-b1b1-9b6e62bbd1ba@proxmox.com> Date: Fri, 27 Mar 2026 11:05:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup v2 0/1] fix #7412: ui: dashboard: persist datastore usage column state To: David Riley , pbs-devel@lists.proxmox.com References: <20260326131837.28941-1-d.riley@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260326131837.28941-1-d.riley@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774605863090 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6GF3AO5PRQ3ADO42374CG6ICEF3V2BGV X-Message-ID-Hash: 6GF3AO5PRQ3ADO42374CG6ICEF3V2BGV X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: hi, just a small nit: usually if a single patch is sent, there is no need for a cover letter, and the comments and changelog can be written below the first '---' part of the patch if it's there it will not end up in the git log On 3/26/26 2:19 PM, David Riley wrote: > Thanks for the review and for testing. > > Differences from v1: > * renamed the `stateId` to match the naming conventions of pbs > * Carried over the `Fixes`, `Reviewed-by` and `Tested-by` trailers. > > David Riley (1): > fix #7412: ui: dashboard: persist datastore usage column state > > www/dashboard/DataStoreStatistics.js | 2 ++ > 1 file changed, 2 insertions(+) >