From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 790A56A2B8 for ; Thu, 16 Sep 2021 09:39:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6A1E42155A for ; Thu, 16 Sep 2021 09:39:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 04FE82154C for ; Thu, 16 Sep 2021 09:39:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CC340448DC for ; Thu, 16 Sep 2021 09:38:59 +0200 (CEST) Message-ID: <5ba7b5b3-3ab0-e7e8-3cb7-fe0c28b01ce9@proxmox.com> Date: Thu, 16 Sep 2021 09:38:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US From: Thomas Lamprecht To: =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= Cc: Proxmox Backup Server development discussion Reply-To: Proxmox Backup Server development discussion References: <20210915134157.19762-1-f.gruenbichler@proxmox.com> <20210915134157.19762-7-f.gruenbichler@proxmox.com> <3411c837-865e-4f66-04e4-05e93b37c6c0@proxmox.com> In-Reply-To: <3411c837-865e-4f66-04e4-05e93b37c6c0@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.107 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.698 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [pve-devel] [PATCH v2 proxmox-backup 06/10] sync: add group filtering X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2021 07:39:00 -0000 On 16.09.21 09:19, Thomas Lamprecht wrote: >> if we want to make this configurable over the GUI, we probably want to switch >> the job edit window to a tabpanel and add a second grid tab for selecting >> the groups > we could also get away by adding it in the advanced section for now. I had a quick talk with Dominik which noticed me that there can be a list of filters. So a separate tab-panel would seem OK to me. For UX I'd could imagine having a "Add Filter" button that'd work out similarly to how we have the knet link add in PVE cluster creation nowadays. In addition to that a preview window would be nice to have, maybe similar to the "Prune now" one, but we only need the backup-groups here not the full list of snapshots, so it would be relatively cheap to get.