From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3C04174F68 for ; Tue, 12 Oct 2021 10:52:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2BC722978D for ; Tue, 12 Oct 2021 10:51:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A24512977F for ; Tue, 12 Oct 2021 10:51:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 73E3A45D25; Tue, 12 Oct 2021 10:51:48 +0200 (CEST) Message-ID: <5a8340d6-8277-d2cc-0eb2-e65984126168@proxmox.com> Date: Tue, 12 Oct 2021 10:51:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Hannes Laimer References: <20211006151457.18508-1-h.laimer@proxmox.com> <20211006151457.18508-2-h.laimer@proxmox.com> From: Dominik Csapak In-Reply-To: <20211006151457.18508-2-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.298 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs] Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 1/4] pbs-api-types: add maintenance-type and msg to ds config X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2021 08:52:19 -0000 any reason why you did not combine the type+message like i suggested? in general it's ok to do it this way, but maybe giving a reason (at least in the patch changelog) would be good On 10/6/21 17:14, Hannes Laimer wrote: > --- > pbs-api-types/src/datastore.rs | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs > index 75f82ea4..d1f3db9a 100644 > --- a/pbs-api-types/src/datastore.rs > +++ b/pbs-api-types/src/datastore.rs > @@ -165,6 +165,26 @@ pub struct PruneOptions { > pub keep_yearly: Option, > } > > +#[api()] > +#[derive(PartialOrd, Debug, Copy, Clone, PartialEq, Serialize, Deserialize)] > +#[serde(rename_all = "lowercase")] > +/// Different maintenance types. > +pub enum MaintenanceType { > + /// Only reading operations are allowed. > + ReadOnly, > + /// Neither reading nor writing is allowed on the datastore. > + Offline, > +} > + > +impl std::fmt::Display for MaintenanceType { > + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { > + match *self { > + MaintenanceType::ReadOnly => write!(f, "read-only"), > + MaintenanceType::Offline => write!(f, "offline"), > + } > + } > +} > + > #[api( > properties: { > name: { > @@ -222,6 +242,15 @@ pub struct PruneOptions { > optional: true, > type: bool, > }, > + "maintenance-type": { > + optional: true, > + type: MaintenanceType, > + }, > + "maintenance-msg": { > + description: "Text that will be shown as a description for the maintenance.", > + optional: true, > + type: String, > + }, > } > )] > #[derive(Serialize,Deserialize,Updater)] > @@ -259,6 +288,10 @@ pub struct DataStoreConfig { > /// Send notification only for job errors > #[serde(skip_serializing_if="Option::is_none")] > pub notify: Option, > + #[serde(skip_serializing_if="Option::is_none")] > + pub maintenance_type: Option, > + #[serde(skip_serializing_if="Option::is_none")] > + pub maintenance_msg: Option, > } > > #[api( >