From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1551E929F5 for ; Mon, 8 Apr 2024 13:11:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E6DDD898B for ; Mon, 8 Apr 2024 13:11:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 8 Apr 2024 13:11:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E011744615 for ; Mon, 8 Apr 2024 13:11:11 +0200 (CEST) Message-ID: <5852b459-85a7-466d-84df-fe98a89f66b7@proxmox.com> Date: Mon, 8 Apr 2024 13:11:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= References: <20240405130543.259220-1-h.duerr@proxmox.com> <20240405130543.259220-4-h.duerr@proxmox.com> <1712568297.ngmgxkzot1.astroid@yuna.none> Content-Language: en-US From: =?UTF-8?Q?Hannes_D=C3=BCrr?= In-Reply-To: <1712568297.ngmgxkzot1.astroid@yuna.none> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.375 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 3/3] docs: add garbage collection timing example X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2024 11:11:15 -0000 On 4/8/24 11:35, Fabian Grünbichler wrote: > On April 5, 2024 3:05 pm, Hannes Duerr wrote: >> To make the garbage collection process easier to understand, we add a >> timing example with a graphic. >> >> Signed-off-by: Hannes Duerr >> --- >> docs/images/garbage-collection-timing.svg | 2513 +++++++++++++++++++++ >> docs/maintenance.rst | 25 + >> 2 files changed, 2538 insertions(+) >> create mode 100644 docs/images/garbage-collection-timing.svg >> >> diff --git a/docs/images/garbage-collection-timing.svg b/docs/images/garbage-collection-timing.svg >> new file mode 100644 >> index 00000000..8108ee23 >> --- /dev/null >> +++ b/docs/images/garbage-collection-timing.svg > [snip] > >> diff --git a/docs/maintenance.rst b/docs/maintenance.rst >> index e25c8f19..a23e5c21 100644 >> --- a/docs/maintenance.rst >> +++ b/docs/maintenance.rst >> @@ -233,6 +233,31 @@ by the GC as it cannot be certain whether they are still needed. >> which is 24 hours by default. >> >> >> +Timing Example >> +^^^^^^^^^^^^^^ >> + >> +.. figure:: images/garbage-collection-timing.svg >> + :class: proxmox-svg >> + :alt: Garbage Collection timing >> + >> +t\ :sub:`0`\: >> +All chunks are part of the backup indices. Some chunks have a newer >> +``atime`` than the cut-off time, while others have not been accessed >> +for a while (e.g. because they were only created by a new backup). >> + >> +t\ :sub:`1`\: >> +A backup has been deleted and some chunks are no longer used >> + >> +t\ :sub:`2`\: >> +The first phase of the GC begins and the ``atime`` of the chunks that >> +are still being used by a backup are updated >> + >> +t\ :sub:`3`\: >> +The second phase of the GC begins. Chunks that have not been used and >> +whose ``atime`` is older than the cut-off time are deleted. Chunks that >> +have not been used but whose ``atime`` is newer than the cut-off time >> +are not yet deleted, but are marked as pending as a precaution. > I think a visualization might help understand how GC, backup tasks and > pruning interact. I am not sure this one is "it", though ;) > > Maybe changing the time to flow downwards would give more space in the > horizontal axis to display indices and chunks at a certain point in > time? At least for me, the arrangement of the chunks between the time > markers throws me off.. As discussed offlist, a possible compromise would be to split the graphics into 3 with descriptive text in between to make it clear that the graphics represent a moment during a phase. >> + >> Manually Starting GC >> ^^^^^^^^^^^^^^^^^^^^ >> >> -- >> 2.39.2 >> >> >> >> _______________________________________________ >> pbs-devel mailing list >> pbs-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >> >> >> > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > >