Re: [PATCH proxmox-backup v3 07/30] pbs-config: implement encryption key config handling

Thomas Lamprecht
2026-04-15T08:07:04Z

On 15/04/2026 08:47, Christian Ebner wrote:
>>>
>>> +    // lock to avoid race with key deletion
>>> +    open_backup_lockfile(&key_lock_path, None, true)?;
>>
>> This needs to be assigned to a variable, no? Otherwise, the lock would
>> be immediately dropped.
>
> Oh, good catch! Indeed without this the lock would be immediately dropped, will be fixed. Thanks!

Might be good to tag the open_backup_lockfile fn with the #[must_use]