Re: [pbs-devel] [PATCH proxmox-backup 0/7] remove objects from s3 backend on datastore destroy

[Christian Ebner <c.ebner@proxmox.com>]

On 7/29/25 3:53 PM, Lukas Wagner wrote:
> On Mon Jul 28, 2025 at 2:39 PM CEST, Christian Ebner wrote:
>> This patch series makes sure the datastore contents are also removed
>> from the s3 backend if the datastore is destroyed with the remove all
>> data flag being set.
>>
>> The first 6 patches fix clippy warnings and refactor the s3 client from
>> datastore config generation into a dedicated helper, since the last
>> patch requires that as well and this would be the third ocurence thereof.
>>
>> The last patch finally does the object store cleanup if the datastore is
>> backed by s3 and the data should be removed. This simply clears all
>> contents starting with the store prefix from the bucket.
>>
> 
> Looks good to me! Also quickly tested this with my minio server.
> Also made sure that it does not delete anything else in the bucket.
> 
> Only thing that maybe could be improved is the wording on the checkbox
> in the "Delete datastore" confirmation dialog. Right now it is:
> 
> 	[ ] Destroy all data (dangerous!)
> 
> Maybe something like this could be more clear:
> 
> 	[ ] Remove data from S3 bucket and local cache (dangerous!)
> 
> But this could also done as a followup, since this is just cosmetic.

Sent the request followup which can be found at:
https://lore.proxmox.com/pbs-devel/20250729165249.855831-1-c.ebner@proxmox.com/T/



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel