From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 81CD61FF15F for ; Mon, 2 Dec 2024 15:33:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9871E1AB0E; Mon, 2 Dec 2024 15:33:43 +0100 (CET) Message-ID: <5649254d-6c85-49fc-85ef-04598811ef37@proxmox.com> Date: Mon, 2 Dec 2024 15:33:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Shannon Sterz References: <20241202141655.254472-1-s.sterz@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v3 1/4] sendmail: add sendmail crate X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 2024-12-02 15:22, Shannon Sterz wrote: > On Mon Dec 2, 2024 at 3:16 PM CET, Shannon Sterz wrote: >> add the `proxmox-sendmail` crate that makes it easier to send mails via >> the `sendmail` utility. features include: >> >> - multipart/alternative support for html+plain text mails >> - multipart/mixed support for mails with attachments >> - automatic nesting of multipart/alternative and multipart/mixed parts >> - masks multiple receivers by default, can be disabled >> - encoding Subject, To, From, and attachment file names correctly >> - adding an `Auto-Submitted` header to avoid triggering automated mails >> >> also includes several tests to ensure that mails are formatted >> correctly. debian packaging is also provided. >> >> Signed-off-by: Shannon Sterz > > forgot to add this in the v2 already, but since that is now obsolete, > but unless Lukas objects this should probably include: > > Tested-by: Lukas Wagner > Reviewed-by: Lukas Wagner > > just thought i'd quickly mention this before it gets lost > Changes look good, so no objection from me. Only tested v1 and v2, but since this has some serious test coverage which I assume you have run before submitting v3, I think the T-b is also okay :) -- - Lukas _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel