From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B50BD90672 for ; Thu, 30 Mar 2023 15:39:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 929281CD81 for ; Thu, 30 Mar 2023 15:39:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 30 Mar 2023 15:38:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 923A341A4A for ; Thu, 30 Mar 2023 15:38:59 +0200 (CEST) Message-ID: <55d3ba8f-c1d4-20b5-7f12-051c21849403@proxmox.com> Date: Thu, 30 Mar 2023 15:38:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Dominik Csapak To: pbs-devel@lists.proxmox.com Reply-To: Proxmox Backup Server development discussion References: <20230330112845.2620964-1-d.csapak@proxmox.com> <20230330112845.2620964-3-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20230330112845.2620964-3-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/4] tape: implement 6 byte fallback for MODE SENSE/SELECT X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2023 13:39:00 -0000 On 3/30/23 13:28, Dominik Csapak wrote: > there are tape drives (esp. virtual ones) that don't implement the > 10-byte variants of MODE SENSE/SELECT. Since the pages we set/request > are never bigger than 255 bytes anyway, we can implement a fallback > with the 6 byte variant here. > > Implementing this as a fallback to make sure that existing working > drives keep the existing implementation. > > Tested with Starwind VTL. > note because if forgot: this patch does not fix pbs tape usage with starwinds vtl completely, there are some things that still don't work, but this fixes these specific commands there and may increase compatibility with other drives too