From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AF05D1FF15E for ; Mon, 27 Oct 2025 11:21:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 46F467E1; Mon, 27 Oct 2025 11:22:01 +0100 (CET) Message-ID: <535e3159-7081-4b37-865d-92f89fa56e9e@proxmox.com> Date: Mon, 27 Oct 2025 11:21:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Christian Ebner References: <20251027093341.4955-1-c.ebner@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251027093341.4955-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761560505639 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, datastore.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup stable-3 0/3] Backport group listing optimizations including bugfix X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Am 27.10.25 um 10:33 schrieb Christian Ebner: > These patches were part of the patch series to introduce the > streaming content api for PBS [0], optimizing the backup group > listing. > > They did however indirectly fix also a bug in the group listing > api call, which lead to the `last-backup` time to be returned > incorrectly in some occasions. This was found and disected in > issue 6956 [1], identifying an incorrect is_finished() check while > folding the snapshot iterator to determine the last finished snapshot > of a group. > > Therefore, instead of just fixing the bug, backport the relevant > patches which also provides the group listing improvements. They all miss your S-o-b trailer, and ideally add the original commit they got backported from, if you use `git -xs cherry-pick ` all this happens automatically. > > While the first 2 patches are preparatory, the last patch actually > fixes the issue. > > [0] https://lore.proxmox.com/pbs-devel/20251008134344.3512958-1-d.csapak@proxmox.com/T/#t > [1] https://bugzilla.proxmox.com/show_bug.cgi?id=6956 > > Dominik Csapak (3): > api: admin: datastore: refactor BackupGroup to GroupListItem > conversion > api: admin: datastore: factor out 'get_group_owner' > api: admin: datastore: optimize `groups` api call > > src/api2/admin/datastore.rs | 134 +++++++++++++++++++++--------------- > 1 file changed, 77 insertions(+), 57 deletions(-) > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel