From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 54B8268D69 for ; Wed, 11 Nov 2020 18:34:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4255626B57 for ; Wed, 11 Nov 2020 18:33:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 277A926B48 for ; Wed, 11 Nov 2020 18:33:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E88B745D57 for ; Wed, 11 Nov 2020 18:33:48 +0100 (CET) To: Proxmox Backup Server development discussion , Mira Limbeck References: <20201110132218.17717-1-m.limbeck@proxmox.com> From: Thomas Lamprecht Message-ID: <5326ebc6-b85b-1427-a381-793bd2f5fbd4@proxmox.com> Date: Wed, 11 Nov 2020 18:33:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201110132218.17717-1-m.limbeck@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.097 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup 1/2] add extra_info field to APTUpdateInfo X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2020 17:34:20 -0000 On 10.11.20 14:22, Mira Limbeck wrote: > Add an optional string field to APTUpdateInfo which can be used for > extra information. >=20 > This is used for passing running kernel and running version information= > in the versions API call together with proxmox-backup and > proxmox-backup-server. >=20 > Signed-off-by: Mira Limbeck > --- > v2: > - renamed additional_info to extra_info to make it compatible with > GUI code > - changed the running_kernel and running_version info to contain th= e > text 'running kernel: ' and 'running version: ' which removes the= > need for special casing in proxmox-backup-manager versions and > makes it again compatible with the GUI >=20 > src/api2/node/apt.rs | 35 ++++++++++++++++++++++++++++------- > src/api2/types/mod.rs | 2 ++ > src/tools/apt.rs | 1 + > 3 files changed, 31 insertions(+), 7 deletions(-) >=20 > applied, thanks! I did some followups restoring the format to the previou= s state, line lengths up to 99 are fine for us, and reducing some lines can help r= ead the code faster as more is visible and thus in the mental state, at least it = feels less bloated to me :-) Can you please address your comment on this patch as followup?