From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F0F1569713 for ; Tue, 27 Jul 2021 09:10:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E56C016BBB for ; Tue, 27 Jul 2021 09:10:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 74EF216BAC for ; Tue, 27 Jul 2021 09:10:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4236040F9D for ; Tue, 27 Jul 2021 09:10:15 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210722134106.1280517-1-d.csapak@proxmox.com> <20210722134106.1280517-5-d.csapak@proxmox.com> From: Dietmar Maurer Message-ID: <52c86cd7-d750-be1d-c1c0-524de933786e@proxmox.com> Date: Tue, 27 Jul 2021 09:10:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210722134106.1280517-5-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 1.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.438 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 4/7] tape: media_catalog: add local type aliases to make code more clear X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 07:10:16 -0000 comments below On 7/22/21 3:41 PM, Dominik Csapak wrote: > by adding some type aliases like 'type Store = String', > the more complex types/return values are easier to read. > > For example > HashMap > > turns into: > HashMap > > since those types are not public, the generated cargo docs, do not > contain them > > Signed-off-by: Dominik Csapak > --- > src/tape/media_catalog.rs | 35 ++++++++++++++++++++--------------- > 1 file changed, 20 insertions(+), 15 deletions(-) > > diff --git a/src/tape/media_catalog.rs b/src/tape/media_catalog.rs > index f7fcdd0a..296d1d2f 100644 > --- a/src/tape/media_catalog.rs > +++ b/src/tape/media_catalog.rs > @@ -31,9 +31,14 @@ use crate::{ > }, > }; > > +type Store = String; > +type Snapshot = String; > +type FileNr = u64; I am not a big fan , but OK. > +type Chunk = [u8; 32]; > + Introducing a special type here no sense - we use &[u8;32] for chunks digests everywhere, so we want to replace that everywhere (not only inside this file)