From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2456D652AC for ; Mon, 2 Nov 2020 21:12:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0BF1F258D6 for ; Mon, 2 Nov 2020 21:12:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E507E258C9 for ; Mon, 2 Nov 2020 21:12:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AF0F14600E for ; Mon, 2 Nov 2020 21:12:55 +0100 (CET) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20201102113439.26618-1-d.csapak@proxmox.com> From: Thomas Lamprecht Message-ID: <52c47ba4-d037-3cfa-ff99-c2465ce74f08@proxmox.com> Date: Mon, 2 Nov 2020 21:12:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201102113439.26618-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.120 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup 0/5] various bug fixes/improvements for gc X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2020 20:12:57 -0000 On 02.11.20 12:34, Dominik Csapak wrote: > these are some improvements/fixes for the garbage_collection >=20 > Dominik Csapak (5): > garbage collect: improve index error messages > backup/{dynamic,fixed}_index: improve error message for small index > files > server/gc_job: add 'to_stdout' > api2/admin/datastore: start the garbage_collection task with our > helper > proxmox-backup-proxy: use only jobstate for garbage_collection > schedule >=20 > src/api2/admin/datastore.rs | 17 +++++------------ > src/backup/datastore.rs | 22 +++++++++++++++++++--- > src/backup/dynamic_index.rs | 20 +++++++++++++------- > src/backup/fixed_index.rs | 19 +++++++++++++------ > src/bin/proxmox-backup-proxy.rs | 23 ++++++----------------- > src/server/gc_job.rs | 3 ++- > 6 files changed, 58 insertions(+), 46 deletions(-) >=20 applied series, thanks! Die two followups. 1. due to a patch of mine the UPID import in proxmox-backup-proxy was now unused, dropped that 2. This: return Err(format_err!( "cannot open index {}: {}", full_path.to_string_lossy(), err, )); is: bail!("can't open index {} - {}", path.to_string_lossy(), err), On another note, I had the feeling that we did not sent out mails for man= ually triggered GCs before this change, not sure if I'm just imagine or if you = changed that, possibly unwillingly?