From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 433B7B3C89 for ; Wed, 29 Nov 2023 14:54:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 257098469 for ; Wed, 29 Nov 2023 14:54:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 14:54:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6490540CF6 for ; Wed, 29 Nov 2023 14:54:01 +0100 (CET) Date: Wed, 29 Nov 2023 14:54:00 +0100 (CET) From: Christian Ebner To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= Message-ID: <523329318.1118.1701266040813@webmail.proxmox.com> In-Reply-To: <1701264220.irmoe4u1io.astroid@yuna.none> References: <20231129113637.204053-1-c.ebner@proxmox.com> <20231129113637.204053-2-c.ebner@proxmox.com> <1701264220.irmoe4u1io.astroid@yuna.none> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev55 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] api: create default prune job on datastore creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 13:54:02 -0000 > On 29.11.2023 14:27 CET Fabian Gr=C3=BCnbichler wrote: >=20 > is this documented anywhere? No, there is no documentation on this. I will have to include that as well = in a new version of the patches. > `proxmox-backup-manager datastore create ..` does not add any > schedules/jobs by default, it's just the web UI that does (but that also > tells you about this, and allows you to override it!) Yes, that is indeed true. I would argue for an increased usability by a def= ault creation of prune job and garbage collection schedules with well documented= defaults for all possible datastore creation routes, and allow to override these def= aults via the optional parameters. Are there objections to such a change in behavior? This should further be considered a breaking change for the API, I suppose. =20 >=20 > I agree that it probably makes sense, but it should be consistent > - web UI does it, but then it should display it (and it would need to > become a new optional parameter here, maybe by extending > "add_datastore", else overriding would not be possible) > - proxmox-backup-manager does it, but then it should also do it for a > "plain" datastore creation by default? You are right in that these patches are not sufficient to create consistent= behavior for all possible cases. I will have to refine and extend this. Thank you for your feedback! Cheers, Chris