From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 559DE99CD for ; Fri, 4 Aug 2023 10:20:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 37B96BD01 for ; Fri, 4 Aug 2023 10:20:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Aug 2023 10:20:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EBE7342BB7 for ; Fri, 4 Aug 2023 10:20:44 +0200 (CEST) Message-ID: <51bf8073-33b4-a484-10cc-0768a984bbaa@proxmox.com> Date: Fri, 4 Aug 2023 10:20:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Content-Language: en-US To: Gabriel Goller References: <20230803152238.124625-1-g.goller@proxmox.com> <836aff2c-4143-577c-5abe-f9601f77293f@proxmox.com> Cc: Proxmox Backup Server development discussion From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.091 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [create.rs] Subject: Re: [pbs-devel] [PATH proxmox-backup] fix #4380: stat() is run when file is executed X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2023 08:20:46 -0000 Am 04.08.23 um 09:54 schrieb Gabriel Goller: > On 8/4/23 09:42, Fiona Ebner wrote: > >> Am 03.08.23 um 17:22 schrieb Gabriel Goller: >>> diff --git a/pbs-client/src/pxar/create.rs >>> b/pbs-client/src/pxar/create.rs >>> index 2577cf98..c573c2a3 100644 >>> --- a/pbs-client/src/pxar/create.rs >>> +++ b/pbs-client/src/pxar/create.rs >>> @@ -434,6 +434,15 @@ impl Archiver { >>>               assert_single_path_component(os_file_name)?; >>>               let full_path = self.path.join(os_file_name); >>>   +            let match_path = >>> PathBuf::from("/").join(full_path.clone()); >>> +            if self >>> +                .patterns >>> +                .matches(match_path.as_os_str().as_bytes(), None) >> Is it fine to call matches() without the file mode in all cases? Can't >> it make a difference for directory matching? If it's okay, please >> explain why in the commit message. > > I think so, because we get the `patterns` (at least those with > MatchType::Exclude) only from the `.pxarexclude` file or from the > command line argument `--exclude`. Both do not allow to specify the file > mode. > But the MatchFlag::MATCH_DIRECTORIES flag is set for the pattern with a trailing slash in match_list.rs's parse_pattern_do() in the pathpatterns create during construction. My concern is that now a file 'foo' will match the pattern 'foo/' when it previously didn't (but I didn't test it).