From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B979D1FF137 for ; Tue, 17 Feb 2026 13:41:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 53DEF3681B; Tue, 17 Feb 2026 13:42:05 +0100 (CET) Message-ID: <5004667b-a4a3-45d0-8baa-d163181be4fd@proxmox.com> Date: Tue, 17 Feb 2026 13:42:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 proxmox-backup 00/18] fix: #3847 pipe from STDIN to proxmox-backup-client To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260210150642.469670-1-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260210150642.469670-1-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771332115082 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CBTDPA2WMFBNOYQJXMHQKD7QNJMOXKKZ X-Message-ID-Hash: CBTDPA2WMFBNOYQJXMHQKD7QNJMOXKKZ X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/10/26 4:06 PM, Robert Obkircher wrote: > Add support for commands like: > ssh host cmd | proxmox-backup-client backup data.img:/dev/stdin > proxmox-backup-client backup a.img:<(mysqldump) b.img:<(pgdump) > > Changes since v5: > > Client: > - add IndexType::to_prefix_and_size helper and fix format string nit > - drop support for '-' but log helpful warnings > - fail early for duplicate pipes > - avoid calling poll_next on terminated streams > > Server: > - mention why Arc can be removed from didx as well > - (Test)TempDir: > - add to parent mod in earlier commit > - drop "Test" from the name > - improved API so it could be moved to a crate (no unwrap in new, > no Deref, no impl From<&TempDir> for PathBuf) > - added tests > - reorder add_chunk commit before grow_to_size > - support reuse-csum with arbitrary sizes > - made up my mind on u32 vs u64 and reordered commits > - check that chunk_size is power of two This series has taken a really nice shape, got nothing to complain code wise and works as expected! Tested: - several input stream variations, via pipe and command substitution - restores produce the same byte stream as the input data - char devices and pts are not allowed - reading from /dev/stdin is not allowed to be duplicated - subsequent backups work without issues - backup and restore of images with given size such as for VMs are unaffected Reviewed-by: Christian Ebner Tested-by: Christian Ebner