From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CD7751FF16E for <inbox@lore.proxmox.com>; Mon, 17 Feb 2025 14:08:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 27BA41F94A; Mon, 17 Feb 2025 14:08:07 +0100 (CET) Date: Mon, 17 Feb 2025 14:08:03 +0100 From: Gabriel Goller <g.goller@proxmox.com> To: Wolfgang Bumiller <w.bumiller@proxmox.com> Message-ID: <4iymtwe46mmc7zn6f2erjkfxhal76ma2xy2fh2d4rk2vaqpik4@7n363ok7f5yf> References: <20241209104606.263045-1-g.goller@proxmox.com> <20241209104606.263045-2-g.goller@proxmox.com> <5cettqvqg6i6y2cgihynjjirl4vyl6c5l3ewbn4ydhccpgc6ac@aj5yojr624d4> <yyzfsgf2p5k52fk67lsu6jzu42egxjqnfgywuermm75ijm7cwg@v4x56bymmlxq> <2cugfnfjfv2robousxhdshdu3rxmyg3bnfdazoyagvn5gglatl@6x4trum24nak> <iidtwwpusvqkcqw6sh7e7mqqnlhu37icz5k77ps5wro2nenr7b@gqi7k24dsw4n> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <iidtwwpusvqkcqw6sh7e7mqqnlhu37icz5k77ps5wro2nenr7b@gqi7k24dsw4n> User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v2 1/4] log: rename/move init functions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Cc: Lukas Wagner <l.wagner@proxmox.com>, pbs-devel@lists.proxmox.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> T24gMTEuMDIuMjAyNSAxMDoyOCwgV29sZmdhbmcgQnVtaWxsZXIgd3JvdGU6Cj5PbiBUdWUsIEZl YiAxMSwgMjAyNSBhdCAxMDoyMjo0NEFNICswMTAwLCBXb2xmZ2FuZyBCdW1pbGxlciB3cm90ZToK Pj4gT24gTW9uLCBGZWIgMTAsIDIwMjUgYXQgMDU6NDI6MzVQTSArMDEwMCwgR2FicmllbCBHb2xs ZXIgd3JvdGU6Cj4+ID4gT24gMTAuMDIuMjAyNSAxNTozNywgV29sZmdhbmcgQnVtaWxsZXIgd3Jv dGU6Cj4+ID4gPiBPbiBNb24sIERlYyAwOSwgMjAyNCBhdCAxMTo0NjowM0FNICswMTAwLCBHYWJy aWVsIEdvbGxlciB3cm90ZToKPj4gPiA+ID4gKy8vLyBJbml0cyBhIG5ldyB0cmFjaW5nIGxvZ2dl ciB0aGF0IHByaW50cyB0byBzdGRlcnIgb3IgdGFza2xvZyB3aXRoIHRoZSBsb2dnaW5nIGxldmVs IHNwZWNpZmllZCBpbiB0aGUKPj4gPiA+ID4gKy8vLyBlbnZpcm9ubWVudCB2YXJpYWJsZSBgZW52 X3ZhcmAuCj4+ID4gPiA+ICsvLy8KPj4gPiA+ID4gKy8vLyBUaGlzIGxvZ2dlciBpcyB0YXNrLWF3 YXJlLCB3aGljaCBtZWFucyBpZiB3ZSBhcmUgaW4gYSBQQlMgdGFzaywgd2Ugd2lsbCByZXRyaWV2 ZSB0aGUgdGFzay1maWxlCj4+ID4gPiA+ICsvLy8gYW5kIHdyaXRlIHRvIGl0LiBXZSdsbCBvbmx5 IHdyaXRlIHRvIHN0ZGVyciBpZiB3ZSBhcmUgbm90IGluIGEgdGFzay4gSWYgYGVudl92YXJgIGRv ZXNuJ3QgZXhpc3QKPj4gPiA+ID4gKy8vLyBvciBjYW4ndCBiZSByZWFkLCB1c2UgdGhlIGBkZWZh dWx0X2xvZ19sZXZlbGAuIFRoZSBvdXRwdXQgd2lsbCBiZSB2ZXJ5IHBsYWluOiBubyBhbnNpLCBu bwo+PiA+ID4gPiArLy8vIHRpbWVzdGFtcCwgbm8gbGV2ZWwsIGp1c3QgdGhlIG1lc3NhZ2UgYW5k IGl0J3MKPj4gPiA+ID4gKy8vLyBmaWVsZHMuCj4+ID4gPiA+ICtwdWIgZm4gc3RkZXJyX29yX3Rh c2tsb2coCj4+ID4gPiA+ICsgICAgZW52X3ZhcjogJnN0ciwKPj4gPiA+ID4gKyAgICBkZWZhdWx0 X2xvZ19sZXZlbDogTGV2ZWxGaWx0ZXIsCj4+ID4gPiA+ICspIC0+IFJlc3VsdDwoKSwgYW55aG93 OjpFcnJvcj4gewo+PiA+ID4gPiArICAgIGxldCBsb2dfbGV2ZWwgPSBnZXRfZW52X3ZhcmlhYmxl KGVudl92YXIsIGRlZmF1bHRfbG9nX2xldmVsKTsKPj4gPiA+ID4gKwo+PiA+ID4gPiArICAgIGxl dCByZWdpc3RyeSA9IHRyYWNpbmdfc3Vic2NyaWJlcjo6cmVnaXN0cnkoKQo+PiA+ID4gPiArICAg ICAgICAud2l0aCgKPj4gPiA+ID4gKyAgICAgICAgICAgIHBsYWluX3N0ZGVycl9sYXllcigpCj4+ ID4gPiA+ICsgICAgICAgICAgICAgICAgLndpdGhfZmlsdGVyKGZpbHRlcl9mbih8X21ldGFkYXRh fCAhTG9nQ29udGV4dDo6ZXhpc3RzKCkpKQo+PiA+ID4KPj4gPiA+IF4gVGhpcyBjb25kaXRpb24g bWlzc2VzIHRoZSBgTGV2ZWw6OkVSUk9SYCBjb21wYXJpc29uIHdoaWxlIGJlaW5nCj4+ID4gPiBz dWdnZXN0ZWQgYXMgYSByZXBsYWNlbWVudCBmb3IgYGluaXRfY2xpX2xvZ2dlcmAgd2hpY2ggaGFk IGl0IChub3QKPj4gPiA+IHZpc2libGUgaW4gdGhlIHBhdGNoIGNvbnRleHQgbGluZXMsIGJ1dCBp dCdzIHRoZXJlKS4KPj4gPiA+IElmIHRoaXMgaXMgZG9uZSBvbiBwdXJwb3NlLCBwbGVhc2UgZXhw bGFpbiBpdCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuCj4+ID4KPj4gPiBPb3BzLCB5ZWFoIG15IGJh ZCwgdGhpcyBzaG91bGQgYmUKPj4gPgo+PiA+ICAgICAhTG9nQ29udGV4dDo6ZXhpc3RzKCkgfHwg Km1ldGFkYXRhLmxldmVsKCkgPT0gTGV2ZWw6OkVSUk9SCj4+ID4KPj4gPiBXaGF0IGRvIHlvdSB0 aGluayBhYm91dCB0aGUgcmVzdCBvZiB0aGUgcGF0Y2g/IEkgdHJpZWQgdG8gaW1wbGVtZW50IHRo aXMKPj4gPiB3aXRoIGEgYnVpbGRlciBwYXR0ZXJuIGFzIHdlbGwsIGJ1dCBpdCB0dXJuZWQgb3V0 IHRvIGJlIHF1aXRlIHRyaWNreQo+PiA+IG1vdmluZyB0aGUgbGF5ZXJzIGFyb3VuZCBzbyBJIGp1 c3Qgd3JvdGUgYSB0b24gb2YgZnVuY3Rpb25zIHdpdGggbG9uZwo+PiA+IG5hbWVzIDooCj4+Cj4+ IFRoZSByZXN0IHNlZW1zIGZpbmUuCj4+IEl0IGRvZXMgbG9vayBsaWtlIGl0IHNob3VsZCBiZSBt b3N0bHkgYSBidWlsZGVyLXBhdHRlcm4gdGhpbmcgKGFzIGl0Cj4+IGtpbmQgb2YgYWxyZWFkeSBp cywgd2l0aCB0aGUgZmluYWwgMiBsaW5lcyBiZWluZyBhIGtpbmQgb2YgYC5hcHBseSgpYCwKPj4g YnV0IHdpdGggdGhlIG5hbWVzIGJlaW5nIHNob3dpbmcgdGhlaXIgaW50ZW5kZWQgdXNlLCBpdCdz IGZpbmUgZm9yIGFuCj4+IGBpbml0YCBtb2R1bGUgdG8gaGF2ZSBzcGVjaWZpYyBjb21tb24gc2V0 dXBzIGxpa2UgdGhpcyAoYGluaXRfY2xpX+KApmAsCj4+IGDigKZ3aXRoX3B2ZV9mb3JtYXRgLCBl dGMuKQo+Pgo+PiBQZXJoYXBzIHRoZSBqb3VybmFsL3Rhc2tsb2cgb25lIGNvdWxkIGJlIG5hbWVk ICJpbml0X2RhZW1vbl9sb2ciIChvcgo+PiBqdXN0IGhhdmUgYW4gYWxpYXMgdW5kZXIgdGhhdCBu YW1lKS4uLgo+Cj5Tb3JyeSwgSSB3YXMgcmVhZGluZyBpdCBiYWNrd2FyZHMsIHdlJ3JlIGdldHRp bmcgcmlkIG9mIHRob3NlIG5hbWVzLi4uCj5UaGF0IGp1c3QgZ29lcyB0byBzaG93IEkgZGlkbid0 IHByb3Blcmx5IHRoaW5rIGFib3V0IHRoaXMuLi4gOi0pCj4KPk5vdywgZmlyc3Qgb2YgYWxsLCBo YXZpbmcgdGhlICJkZXNjcmlwdGl2ZSIgbmFtZXMgdGhlcmUgbWFrZXMgc2Vuc2UuCj5XaXRoIHRo ZSBgcHZlYCBzcGVjaWZpYyBmdW5jdGlvbiB3ZSB0aGVuIHN0aWxsIGhhdmUgYSByYXRoZXIgc3Bl Y2lmaWMKPm9uZS4KPlRoZXJlZm9yZSwgd2l0aCBhIHNwZWNpZmljIGBpbml0YCBtb2R1bGUsIGl0 IHdvdWxkIElNTyBiZSBmaW5lIHRvIGhhdmUKPnNpdHVhdGlvbi1zcGVjaWZpYyBuYW1lcyBmb3Ig Y29tbW9uIHNldHVwcy4KPgo+VW5sZXNzIHdlIGNhbiBhY3R1YWxseSBjb21lIHVwIHdpdGggYSBi dWlsZGVyLXBhdHRlcm4gdmFyaWFudC4KPlBlcmhhcHMgaXQgd291bGQgaGF2ZSB0byBiZSB0aGUg TGF5ZXIgdHlwZSByYXRoZXIgdGhhbiB0aGUgc3Vic2NyaWJlcgo+d2UnZCBuZWVkIHRvIHR1cm4g aW50byBhIGJ1aWxkZXIsIHdoaWxlIGhhdmluZyBpdHMgZmluYWwgImFwcGx5IiBjcmVhdGUKPnRo ZSBzdWJzY3JpYmVyIGFuZCByZWdpc3RlciBpdCBhbmQgaW5pdGlhbGl6ZSB0aGUgTG9nVHJhY2Vy LgoKSSBjb29rZWQgdXAgYSBzaW1wbGUgYnVpbGRlciB0eXBlIHRoaW5neSB0byBidWlsZCBsYXll cnM6CgoKICAgICBzdHJ1Y3QgTG9nQnVpbGRlciB7CiAgICAgICAgIGdsb2JhbF9sb2dfbGV2ZWw6 IExldmVsRmlsdGVyLAogICAgICAgICBsYXllcjogVmVjPAogICAgICAgICAgICAgQm94PGR5biB0 cmFjaW5nX3N1YnNjcmliZXI6OkxheWVyPHRyYWNpbmdfc3Vic2NyaWJlcjo6UmVnaXN0cnk+ICsg U2VuZCArIFN5bmMgKyAnc3RhdGljPiwKICAgICAgICAgPiwKICAgICB9CgoKQW5kIHRoZSBpbXBs ZW1lbnRhdGlvbjoKCiAgICAgaW1wbCBMb2dCdWlsZGVyIHsKICAgICAgICAgcHViIGZuIGZyb21f ZW52KGVudl92YXI6ICZzdHIsIGRlZmF1bHRfbG9nX2xldmVsOiBMZXZlbEZpbHRlcikgLT4gTG9n QnVpbGRlciB7CiAgICAgICAgICAgICBsZXQgbG9nX2xldmVsID0gZ2V0X2Vudl92YXJpYWJsZShl bnZfdmFyLCBkZWZhdWx0X2xvZ19sZXZlbCk7CiAgICAgICAgICAgICBMb2dCdWlsZGVyIHsKICAg ICAgICAgICAgICAgICBnbG9iYWxfbG9nX2xldmVsOiBsb2dfbGV2ZWwsCiAgICAgICAgICAgICAg ICAgbGF5ZXI6IHZlYyFbXSwKICAgICAgICAgICAgIH0KICAgICAgICAgfQoKICAgICAgICAgcHVi IGZuIGpvdXJuYWxkX29yX3N0ZGVycihtdXQgc2VsZikgLT4gTG9nQnVpbGRlciB7CiAgICAgICAg ICAgICBzZWxmLmxheWVyLnB1c2goCiAgICAgICAgICAgICAgICAgam91cm5hbGRfb3Jfc3RkZXJy X2xheWVyKCkKICAgICAgICAgICAgICAgICAgICAgLndpdGhfZmlsdGVyKHNlbGYuZ2xvYmFsX2xv Z19sZXZlbCkKICAgICAgICAgICAgICAgICAgICAgLmJveGVkKCksCiAgICAgICAgICAgICApOwog ICAgICAgICAgICAgc2VsZgogICAgICAgICB9CgogICAgICAgICBwdWIgZm4gam91cm5hbGRfb3Jf c3RkZXJyX29uX2xvZ2NvbnRleHRfYW5kX2Vycm9yKG11dCBzZWxmKSAtPiBMb2dCdWlsZGVyIHsK ICAgICAgICAgICAgIHNlbGYubGF5ZXIucHVzaCgKICAgICAgICAgICAgICAgICBqb3VybmFsZF9v cl9zdGRlcnJfbGF5ZXIoKQogICAgICAgICAgICAgICAgICAgICAud2l0aF9maWx0ZXIoZmlsdGVy X2ZuKHxtZXRhZGF0YXwgewogICAgICAgICAgICAgICAgICAgICAgICAgIUxvZ0NvbnRleHQ6OmV4 aXN0cygpIHx8ICptZXRhZGF0YS5sZXZlbCgpID09IExldmVsOjpFUlJPUgogICAgICAgICAgICAg ICAgICAgICB9KSkKICAgICAgICAgICAgICAgICAgICAgLndpdGhfZmlsdGVyKHNlbGYuZ2xvYmFs X2xvZ19sZXZlbCkKICAgICAgICAgICAgICAgICAgICAgLmJveGVkKCksCiAgICAgICAgICAgICAp OwogICAgICAgICAgICAgc2VsZgogICAgICAgICB9CgogICAgICAgICAvLy4uLgoKICAgICAgICAg cHViIGZuIGluaXQoc2VsZikgLT4gUmVzdWx0PCgpLCBhbnlob3c6OkVycm9yPiB7CiAgICAgICAg ICAgICBsZXQgcmVnaXN0cnkgPSB0cmFjaW5nX3N1YnNjcmliZXI6OnJlZ2lzdHJ5KCkud2l0aChz ZWxmLmxheWVyKTsKICAgICAgICAgICAgIHRyYWNpbmc6OnN1YnNjcmliZXI6OnNldF9nbG9iYWxf ZGVmYXVsdChyZWdpc3RyeSk/OwoKICAgICAgICAgICAgIExvZ1RyYWNlcjo6aW5pdF93aXRoX2Zp bHRlcihzZWxmLmdsb2JhbF9sb2dfbGV2ZWwuYXNfbG9nKCkpPzsKICAgICAgICAgICAgIE9rKCgp KQogICAgICAgICB9CiAgICAgfQoKV2UgY291bGQgcGxhY2UgdGhpcyBpbiBhIG5ldyBidWlsZGVy IG1vZHVsZSBhbmQgdGhlbiBoYXZlIHRoZQpwcm9kdWN0LXNwZWNpZmljIGZ1bmN0aW9ucyAoZS5n LiBpbml0X3B2ZV9sb2csIGluaXRfcGVybG1vZF9sb2csCmluaXRfcGJzX2xvZywgZXRjLikgaW4g dGhlIGluaXQgbW9kdWxlLgoKV2hhdCBkbyB5b3UgdGhpbms/CgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcGJzLWRldmVsIG1haWxpbmcgbGlzdApwYnMt ZGV2ZWxAbGlzdHMucHJveG1veC5jb20KaHR0cHM6Ly9saXN0cy5wcm94bW94LmNvbS9jZ2ktYmlu L21haWxtYW4vbGlzdGluZm8vcGJzLWRldmVsCg==