From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DFC5491856 for ; Fri, 7 Oct 2022 15:37:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9FD3268A1 for ; Fri, 7 Oct 2022 15:36:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Oct 2022 15:36:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 765A04480E for ; Fri, 7 Oct 2022 15:36:52 +0200 (CEST) Message-ID: <4f146682-3f1e-9e96-fb58-00233457811e@proxmox.com> Date: Fri, 7 Oct 2022 15:36:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Dominik Csapak References: <20221006090812.1491248-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221006090812.1491248-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, jobs.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] fix #4274: implement prune notifications X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2022 13:37:23 -0000 Am 06/10/2022 um 11:08 schrieb Dominik Csapak: > we converted the prune settings of datastores to prune-jobs, but did > not actually implement the notifications for them, even though > we had the notification options in the gui (they did not work). > > implement the basic ok/error notification for prune jobs > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * include 'fix #' in the commit subject > * call lookup_datastore_notify_settings directly in the send helper > * fix compilation errors > * rebase on master > pbs-api-types/src/jobs.rs | 6 +++ > src/api2/config/datastore.rs | 1 + > src/server/email_notifications.rs | 77 +++++++++++++++++++++++++++++++ > src/server/prune_job.rs | 7 ++- > www/datastore/OptionView.js | 2 +- > www/window/NotifyOptions.js | 2 +- > 6 files changed, 91 insertions(+), 4 deletions(-) > > applied, thanks!