Re: [PATCH] client: support individual repository component parameters

Thomas Lamprecht
2026-03-30T18:28:42Z

Am 24.03.26 um 16:58 schrieb Maximiliano Sandoval:
>> +.. Note:: Remember to quote API token identifiers on the shell, since the
>> + exclamation mark (``!``) is a special character in most shells
> This makes me wonder if there should too be a dedicated --api-token
> parameter too (that basically appends `!tokenname` to the user). I ran
> into this issue a couple of times in the past, while having it in the
> documentation is good, perhaps it is not the first place one would look
> for this.

Maybe, but that would then need to be adapted also in the user interfaces
(PBS remote, PVE storage, PDM remote, maybe others) for consistency. And
it probably can be it's own change set, so I did not wanted to think to
much about this for the v2 to avoid having it blocked by some additional
potential improvement (should be still easier to implement on top of this
series, if we decide that we actually want it).

>> +
>> The web interface provides copyable repository text in the datastore summary
>> with the `Show Connection Information` button.
>>
>> @@ -70,6 +114,22 @@ Environment Variables
>> ``PBS_REPOSITORY``
>> The default backup repository.
>>
>> +``PBS_SERVER``
>> + Default backup server address. Used as a fallback when neither
>> + ``--repository`` / ``PBS_REPOSITORY`` nor ``--server`` is given.
>> + Requires ``PBS_DATASTORE`` to be set as well.
> I am not sure about the use of "default", since one has to specify one
> or the other. I would personally say something like:
>
> Backup server address. Requires to be used in conjunction to --datastore
> or PBS_DATASTORE. This option is not compatible with --repository or
> PBS_REPOSITORY.

ack