From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D443369BF9 for ; Wed, 28 Jul 2021 12:35:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6E65235E6 for ; Wed, 28 Jul 2021 12:35:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 568DA235D8 for ; Wed, 28 Jul 2021 12:35:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 245A042B50 for ; Wed, 28 Jul 2021 12:35:30 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210728100511.2862784-1-d.csapak@proxmox.com> <20210728100511.2862784-3-d.csapak@proxmox.com> From: Dietmar Maurer Message-ID: <4dd9edc4-c22f-9277-75e5-1226dd885663@proxmox.com> Date: Wed, 28 Jul 2021 12:35:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210728100511.2862784-3-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.764 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup 2/3] tape: changer: handle libraries that sends wrong amount of data X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 10:35:30 -0000 applied On 7/28/21 12:05 PM, Dominik Csapak wrote: > if the library sends more data than advertised, simply cut it off, > but if it sends less data, bail out (depending on how much data is > missing, trying to parse it could lead to a panic, so bail out early) > > Signed-off-by: Dominik Csapak > --- > src/tape/changer/sg_pt_changer.rs | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/src/tape/changer/sg_pt_changer.rs b/src/tape/changer/sg_pt_changer.rs > index 2c5434f6..7ff9bc9d 100644 > --- a/src/tape/changer/sg_pt_changer.rs > +++ b/src/tape/changer/sg_pt_changer.rs > @@ -692,6 +692,15 @@ fn decode_element_status_page( > bail!("got wrong first_element_address_reported"); // sanity check > } > > + let len = head.byte_count_of_report_available; > + let len = ((len[0] as usize) << 16) + ((len[1] as usize) << 8) + (len[2] as usize); > + > + if len < reader.len() { > + reader = &reader[..len]; > + } else if len > reader.len() { > + bail!("wrong amount of data: expected {}, got {}", len, reader.len()); > + } > + > loop { > if reader.is_empty() { > break;