From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0E2277B357 for ; Wed, 12 May 2021 08:44:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EEF469411 for ; Wed, 12 May 2021 08:44:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 69BB292EB for ; Wed, 12 May 2021 08:44:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 37F3446547 for ; Wed, 12 May 2021 08:44:03 +0200 (CEST) Message-ID: <4dc3a2eb-496f-8c74-d2f6-90d027047e52@proxmox.com> Date: Wed, 12 May 2021 08:44:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Dominik Csapak , Proxmox Backup Server development discussion References: <20210511124256.15324-1-d.csapak@proxmox.com> <832918dd-13b3-cd87-e0f5-50b8e97ae97d@proxmox.com> From: Thomas Lamprecht In-Reply-To: <832918dd-13b3-cd87-e0f5-50b8e97ae97d@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.007 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: tape/BackupOverview: add 'restore partial' button X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 May 2021 06:44:34 -0000 On 12.05.21 08:22, Dominik Csapak wrote: > On 5/11/21 18:17, Thomas Lamprecht wrote: >> On 11.05.21 14:42, Dominik Csapak wrote: >>> this opens the restore window, but with a snapshot selector, so that >>> the user can select the snapshots to restore >>> >>> includes a textfield for basic filtering >> >> >> why isn't that handled directly in the restore window, without extra buttons? >> Could possibly be a radio group there. > > yes you're right, that'll much better, though i would not do a radio button, but maybe only a checkbox '[] Select snapshots' which > enables the selection grid? > > we could then open that window with a preselected(and filtered?) list when the user clicks on the 'restore single snapshot' button? > > does that make sense? yes, can make sense - would be related to the backup-job edit window in PVE. IMO slightly better than radio-group/checkbox as it removes a UI control element completely, so less choice/confusion, but without scarifying flexibility, so IMO a good idea. >> >> I really want to avoid many buttons in places like top-bars, makes it crowded >> and confusing.. >> >> Also, why doesn't this uses action buttons for those things like the content >> tree? IMO we should try to be consistent with UX, cross-product this may be >> hard and lots of work, but I do not see any excuse for intra-product consistency >> (especially on rather simple UIs like PBS, compared to PVE). > > mhmm sounds good, i'd do an action column where each media set and > snapshot gets a restore button, and for single snapshots i preselect > like i mentioned above.. does that make sense? > yeah, if the others are still shown for the single snapshot I'd try to scroll it in view or order it first though, so its immediately visible. We could even order selected generally first by default, just an idea though... > (we could probably do a restore button on every level in the tree, > and preselect accordingly, though i am unsure if that does not > get too confusing and if its even helpful...) >