From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 124D5E51C for ; Fri, 9 Dec 2022 11:46:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E8C5122C0F for ; Fri, 9 Dec 2022 11:45:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 9 Dec 2022 11:45:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2EC2F4438D for ; Fri, 9 Dec 2022 11:45:59 +0100 (CET) Message-ID: <4d6b3e2d-2cfa-0e38-1c9e-94bc79170dea@proxmox.com> Date: Fri, 9 Dec 2022 11:45:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Wolfgang Bumiller Cc: pbs-devel@lists.proxmox.com References: <20221207093819.75847-1-l.wagner@proxmox.com> <20221207093819.75847-2-l.wagner@proxmox.com> <20221209091352.qxph4w7hy6jfvjih@wobu-vie.proxmox.com> From: Lukas Wagner In-Reply-To: <20221209091352.qxph4w7hy6jfvjih@wobu-vie.proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.322 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.288 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 1/4] debug cli: show more file attributes for `diff archive` command X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2022 10:46:00 -0000 On 12/9/22 10:13, Wolfgang Bumiller wrote: >> + (EntryKind::Device(a), EntryKind::Device(b)) => { >> + changed.content = a.major != b.major || a.minor != b.minor > > Just noticed - we might be missing a change between blockdev/chardev > here? Might need to include > > file_a.metadata().stat.is_blockdev() != file_b.metadata().stat.is_blockdev() > > as well? Or am I missing this being handled elsewhere already?> Yes, you are absolutely correct, this is something that I've missed here. Will be fixed in the next version of the patch series. -- Best Regards, Lukas Wagner