From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3DA97649C0 for ; Fri, 30 Oct 2020 16:44:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2CD0015801 for ; Fri, 30 Oct 2020 16:44:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4022E157F6 for ; Fri, 30 Oct 2020 16:44:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D9AF345FB2 for ; Fri, 30 Oct 2020 16:44:52 +0100 (CET) To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20201030113644.2044947-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht Message-ID: <4c6cde31-badd-0f37-8760-e4c5aa76dd28@proxmox.com> Date: Fri, 30 Oct 2020 16:44:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201030113644.2044947-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.121 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sync.rs, remote.rs, acl.rs, verify.rs, datastore.rs, pull.rs] Subject: [pbs-devel] partially-applied: [PATCH proxmox-backup 0/8] permission improvements X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2020 15:44:57 -0000 On 30.10.20 12:36, Fabian Gr=C3=BCnbichler wrote: > this series cleans up > - get/set_notes permissions > - unused PRIV_REMOTE_PRUNE >=20 > reworks verification permissions: > - add a new PRIV_DATASTORE_VERIFY that allows verifying whole datastore= s > - allows unprivileged users to verify their part of a datastore in bulk= > - allows non-superusers to setup and view verification jobs (if they ar= e > privileged enough) >=20 > reworks pulls/syncs: > - allow setting an owner > - allow non-superusers to setup and view sync jobs (if they are > privileged enough) >=20 > Fabian Gr=C3=BCnbichler (8): > privs: allow reading notes with Datastore.Audit > privs: use Datastore.Modify|Backup to set backup notes > verify: introduce & use new Datastore.Verify privilege > verify jobs: add permissions > sync: add owner > sync: allow sync for non-superusers > privs: remove PRIV_REMOVE_PRUNE > privs: add some more comments explaining privileges >=20 > src/api2/admin/datastore.rs | 34 ++++++-- > src/api2/admin/sync.rs | 30 ++++++- > src/api2/config/remote.rs | 15 +++- > src/api2/config/sync.rs | 152 +++++++++++++++++++++++++++++++++---= > src/api2/config/verify.rs | 41 +++++++++- > src/api2/pull.rs | 5 +- > src/backup/verify.rs | 29 ++++++- > src/config/acl.rs | 24 ++++-- > src/config/sync.rs | 28 ++++++- > src/server/verify_job.rs | 2 +- > www/config/SyncView.js | 14 +++- > www/window/SyncJobEdit.js | 20 +++++ > 12 files changed, 352 insertions(+), 42 deletions(-) >=20 applied all but the sync related ones (patch 5/8 and 6/8), need some more= thoughts and another opinion would not hurt there - thanks!