From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <a.lauterer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 3B68E68D7F
 for <pbs-devel@lists.proxmox.com>; Mon,  3 Aug 2020 11:45:32 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 2E6A72C7AB
 for <pbs-devel@lists.proxmox.com>; Mon,  3 Aug 2020 11:45:32 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 2155D2C7A0
 for <pbs-devel@lists.proxmox.com>; Mon,  3 Aug 2020 11:45:31 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DC55E43387
 for <pbs-devel@lists.proxmox.com>; Mon,  3 Aug 2020 11:45:30 +0200 (CEST)
To: pbs-devel@lists.proxmox.com
References: <20200729083338.28581-1-a.lauterer@proxmox.com>
 <44ae1142-687b-1221-113d-58e4fd745cdd@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
Message-ID: <4a4e6d7d-28a8-fcb2-b76d-288b78ef4ad8@proxmox.com>
Date: Mon, 3 Aug 2020 11:45:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.0.1
MIME-Version: 1.0
In-Reply-To: <44ae1142-687b-1221-113d-58e4fd745cdd@proxmox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.703 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -1.458 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup] gui: user: fix #2898 add
 dialog to set password
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2020 09:45:32 -0000



On 7/30/20 10:22 AM, Dominik Csapak wrote:
> works as intended, one nit inline
> 
> other than that:
> 
> Reviewed-By: Dominik Csapak <d.csapak@proxmox.com>
> Tested-By: Dominik Csapak <d.csapak@proxmox.com>
> 
>> +
>> +    getValues: function(dirtyOnly) {
>> +    var me = this;
>> +
>> +    var values = me.callParent(arguments);
>> +
>> +    return values;
>> +    },
> 
> if we only call callParent, is it necessary to have it at all?

You are right. Forgot to strip that after copy and pasta. Will send a v2.