From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id D2B1A708A5 for ; Fri, 14 May 2021 10:59:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id BC46B14E15 for ; Fri, 14 May 2021 10:58:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id 0233814E07 for ; Fri, 14 May 2021 10:58:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id C02CD42B9B; Fri, 14 May 2021 10:58:43 +0200 (CEST) Message-ID: <49e3c3f9-9042-1f90-a572-225d90e8b717@proxmox.com> Date: Fri, 14 May 2021 10:58:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20210514084220.10174-1-d.csapak@proxmox.com> <659aa238-6077-5fc5-0f1b-f886a493aca5@proxmox.com> From: Dominik Csapak In-Reply-To: <659aa238-6077-5fc5-0f1b-f886a493aca5@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup] proxmox-restore-daemon: keep daemon active during extract api call X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 08:59:14 -0000 On 5/14/21 10:54, Thomas Lamprecht wrote: > On 14.05.21 10:42, Dominik Csapak wrote: >> we only called watchdog_ping on the start of an api call, which meant >> that if a single zip/pxar download took longer than 10 minutes >> (which can happen on larger vms/slower connections), we shut-down >> the vm and cancelled the download. >> >> instead, spawn a second future, that polls both a sleep and the extract >> handle, and ping the watchdog every 60 seconds >> > > This is known and Stefan send a patch for this last week[0], which was OK but > delayed due to the tokio DuplexStream bug he also fixed where we did not > decided then if we still use his workaround after upstream already merged > the fix. > > IIRC your approach has some drawbacks, especially without the workaround fixed, > but just some fain memory - in any way I'll go for Stefan's series. > > [0]: https://lists.proxmox.com/pipermail/pbs-devel/2021-May/003106.html > ah yes i see it now, thanks :)