From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <l.wagner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 87F9DCDE5
 for <pbs-devel@lists.proxmox.com>; Tue, 19 Sep 2023 15:38:56 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 6F6D5B419
 for <pbs-devel@lists.proxmox.com>; Tue, 19 Sep 2023 15:38:26 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Tue, 19 Sep 2023 15:38:25 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6205C47FCC
 for <pbs-devel@lists.proxmox.com>; Tue, 19 Sep 2023 15:38:25 +0200 (CEST)
Message-ID: <4984a2b1-a856-4a5e-b6ea-5c3873f07949@proxmox.com>
Date: Tue, 19 Sep 2023 15:38:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Hannes Laimer <h.laimer@proxmox.com>
References: <20230915065457.352953-1-h.laimer@proxmox.com>
 <20230915065457.352953-11-h.laimer@proxmox.com>
Content-Language: de-AT, en-US
In-Reply-To: <20230915065457.352953-11-h.laimer@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.032 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 10/23] ui: add removable
 datastore creation support
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2023 13:38:56 -0000



On 9/15/23 08:54, Hannes Laimer wrote:

> +			    change: function(checkbox, newValue) {
> +				const inputPanel = checkbox.up('inputpanel');
> +				const pathField = inputPanel.down('[name=path]');
> +				const uuidField = inputPanel.down('[name=backing-device]');
> +

To quote our JS style guide [1]:
   Avoid using const for everything, but rather in the sense of
   constants. JavaScript is to dynamic for it to provide actual benefits
   if used as default.

... So maybe rather use `let` :). Also applies to some of the following 
commits.

[1] https://pve.proxmox.com/wiki/Javascript_Style_Guide#Variables

-- 
- Lukas