From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 845C81FF15C for ; Wed, 13 Nov 2024 09:23:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 640E1FE16; Wed, 13 Nov 2024 09:23:40 +0100 (CET) Date: Wed, 13 Nov 2024 09:23:07 +0100 (CET) From: Christian Ebner To: Thomas Lamprecht , Proxmox Backup Server development discussion Message-ID: <494560983.2860.1731486187400@webmail.proxmox.com> In-Reply-To: <2f517888-16a8-4006-8417-ccc124bd04cb@proxmox.com> References: <20240926123437.192228-1-c.ebner@proxmox.com> <2f517888-16a8-4006-8417-ccc124bd04cb@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev69 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup 1/2] client: pxar: perform match pattern check only once X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" > On 12.11.2024 21:25 CET Thomas Lamprecht wrote: > > > Am 26.09.24 um 14:34 schrieb Christian Ebner: > > While traversing the filesystem tree, `generate_directory_file_list` > > generates the list of entries to include for each directory level, > > already matching the entry against the given list of match patterns. > > > > Since this already excludes entries which should not be included in > > the archive, the same check in the `add_entry` call is redundant, > > as it is executed for each entry which is included in the list > > generated by `generate_directory_file_list`. > > > > Signed-off-by: Christian Ebner > > --- > > Seems to be present since commit: > > c443f58b09 ("switch to external pxar and fuse crates") > > feel free to add commit references to the commit message itself. Acked, will do next time. Did not include it there directly as it does not really fix anything, just drops redundant code and I investigated why it was introduced like this. > > > > > Noticed while looking at the code because an user reported an issue in > > the community forum, the issue turned out to be unrelated: > > https://forum.proxmox.com/threads/154995/ > > > > pbs-client/src/pxar/create.rs | 9 --------- > > 1 file changed, 9 deletions(-) > > > > > > applied series, thanks! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel