From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 81F9F653CA
 for <pbs-devel@lists.proxmox.com>; Tue,  3 Nov 2020 08:15:11 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 6C3F028BE0
 for <pbs-devel@lists.proxmox.com>; Tue,  3 Nov 2020 08:14:41 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id EE29D28BD2
 for <pbs-devel@lists.proxmox.com>; Tue,  3 Nov 2020 08:14:40 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B654645FFD
 for <pbs-devel@lists.proxmox.com>; Tue,  3 Nov 2020 08:14:40 +0100 (CET)
To: Dietmar Maurer <dietmar@proxmox.com>,
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>,
 Thomas Lamprecht <t.lamprecht@proxmox.com>
References: <20201102113439.26618-1-d.csapak@proxmox.com>
 <52c47ba4-d037-3cfa-ff99-c2465ce74f08@proxmox.com>
 <1427468580.642.1604380298736@webmail.proxmox.com>
From: Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <48b00d80-a6ce-0d98-014d-647681440d7a@proxmox.com>
Date: Tue, 3 Nov 2020 08:14:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <1427468580.642.1604380298736@webmail.proxmox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.414 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup 0/5] various bug
 fixes/improvements for gc
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2020 07:15:11 -0000



On 11/3/20 6:11 AM, Dietmar Maurer wrote:
>> return Err(format_err!(
>>      "cannot open index {}: {}",
>>      full_path.to_string_lossy(),
>>      err,
>> ));
>>
>> is:
>>
>> bail!("can't open index {} - {}", path.to_string_lossy(), err),
> 
> btw, I normally use the following instead:
> 
> bail!("can't open index {:?} - {}", path, err),
> 

yes that is better... (i somehow thought that would print the path as
byte array, idk why i thought that)