From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0F7581FF183 for <inbox@lore.proxmox.com>; Wed, 4 Jun 2025 14:33:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B6C963C0B6; Wed, 4 Jun 2025 14:33:30 +0200 (CEST) Message-ID: <47d9aaec-b8f7-4852-ac7f-e550044f7df6@proxmox.com> Date: Wed, 4 Jun 2025 14:32:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20250515124138.55436-1-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer <h.laimer@proxmox.com> In-Reply-To: <20250515124138.55436-1-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] superseded: Re: [PATCH proxmox/proxmox-backup v2 0/8] trigger sync jobs on mount X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> superseded by: https://lore.proxmox.com/pbs-devel/20250604123054.87007-1-h.laimer@proxmox.com/T/#m9a65d2b7f58ada01d6394bb96391fea62ab444b9 On 5/15/25 14:41, Hannes Laimer wrote: > Sync jobs now have a run-on-mount flag, that, if set, runs the job whenever > a relevant removable datastore is mounted. > > This depends on [1], without it the api process does not drop the file > handle on the `.lock` file which leads to the datastore being not > unmountable after sync jobs were triggered. (now thinking about it, > might have made sense to include it in this series directly, but it also > does make sense on its own) > > v2, thanks @Chris: > - rebased onto master > - improve some docstrings > - move/fix config flag > - drop not-needed changes for the manager binary > - ui: move checkbox to advenced section + don't clear schedule field > - fix test > - actually check the configured flag when deciding if a job should > run... > > [1] https://lore.proxmox.com/pbs-devel/20250512125933.156192-1-h.laimer@proxmox.com/T/#u > > > proxmox: > Hannes Laimer (2): > rest-server: add function that returns a join handle for spawn > pbs-api-types: add run-on-mount flag to SyncJobConfig > > pbs-api-types/src/jobs.rs | 8 ++++++++ > proxmox-rest-server/src/worker_task.rs | 24 ++++++++++++++++++++++-- > 2 files changed, 30 insertions(+), 2 deletions(-) > > proxmox-backup: > Hannes Laimer (6): > api: config: sync: update run-on-mount correctly > api: admin: run configured sync jobs when a datastore is mounted > api: admin: trigger sync jobs only on datastore mount > bin: manager: run uuid_mount/mount tasks on the proxy > ui: add run-on-mount checkbox to SyncJob form > ui: add task title for triggering sync jobs > > src/api2/admin/datastore.rs | 97 +++++++++++++++++++-- > src/api2/admin/sync.rs | 2 +- > src/api2/config/sync.rs | 9 ++ > src/bin/proxmox_backup_manager/datastore.rs | 41 ++++++--- > src/server/sync.rs | 7 +- > www/Utils.js | 1 + > www/window/SyncJobEdit.js | 13 ++- > 7 files changed, 148 insertions(+), 22 deletions(-) > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel