From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BC3E375979 for ; Tue, 13 Jul 2021 12:05:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A6A411FA2D for ; Tue, 13 Jul 2021 12:05:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2267F1FA1D for ; Tue, 13 Jul 2021 12:05:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E546D40E24 for ; Tue, 13 Jul 2021 12:05:00 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210713091125.2064985-1-d.csapak@proxmox.com> <20210713091125.2064985-2-d.csapak@proxmox.com> From: Dietmar Maurer Message-ID: <46ebb399-24a4-0b1a-ab98-2bba9c3efc39@proxmox.com> Date: Tue, 13 Jul 2021 12:05:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210713091125.2064985-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.918 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [restore.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup 2/2] api2: tape: restore: add warning for list restore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 10:05:31 -0000 applied On 7/13/21 11:11 AM, Dominik Csapak wrote: > if an error occurs, the snapshot dirs will already be created, and we > do not clean them up (some might already be finished). > > Warn the user that they are not cleaned up. > > Signed-off-by: Dominik Csapak > --- > src/api2/tape/restore.rs | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/api2/tape/restore.rs b/src/api2/tape/restore.rs > index 68033c4a..f959a856 100644 > --- a/src/api2/tape/restore.rs > +++ b/src/api2/tape/restore.rs > @@ -647,6 +647,10 @@ fn restore_list_worker( > Ok(()) > }); > > + if res.is_err() { > + task_warn!(worker, "Error during restore, partially restored snapshots will NOT be cleaned up"); > + } > + > match std::fs::remove_dir_all(&base_path) { > Ok(()) => {} > Err(err) => task_warn!(worker, "error cleaning up: {}", err),