From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 78FDD1FF16B for ; Fri, 21 Nov 2025 15:14:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B07D922CE6; Fri, 21 Nov 2025 15:15:04 +0100 (CET) Message-ID: <4542d937-1675-48ee-a2a9-7f126aa0bf44@proxmox.com> Date: Fri, 21 Nov 2025 15:15:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Nicolas Frey References: <20251121123209.198368-1-n.frey@proxmox.com> <20251121123209.198368-2-n.frey@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20251121123209.198368-2-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763734469052 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: add verify-job-{read, verify}-threads to tuning options X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/21/25 1:32 PM, Nicolas Frey wrote: > to determine the default number of threads to use for verify jobs on > the datastore level > > Signed-off-by: Nicolas Frey > --- > adds it to the tuning options, though it can easily be moved into its > own setting within the datastore configuration if desired > > pbs-api-types/src/datastore.rs | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs > index a214ac25..176c0d4a 100644 > --- a/pbs-api-types/src/datastore.rs > +++ b/pbs-api-types/src/datastore.rs > @@ -19,7 +19,8 @@ use crate::{ > BACKUP_ID_RE, BACKUP_NS_RE, BACKUP_TIME_RE, BACKUP_TYPE_RE, DATASTORE_NOTIFY_STRING_SCHEMA, > GC_SCHEDULE_SCHEMA, GROUP_OR_SNAPSHOT_PATH_REGEX_STR, PROXMOX_SAFE_ID_FORMAT, > PROXMOX_SAFE_ID_REGEX_STR, PRUNE_SCHEDULE_SCHEMA, SHA256_HEX_REGEX, SINGLE_LINE_COMMENT_SCHEMA, > - SNAPSHOT_PATH_REGEX_STR, UPID, > + SNAPSHOT_PATH_REGEX_STR, UPID, VERIFY_JOB_READ_THREADS_SCHEMA, > + VERIFY_JOB_VERIFY_THREADS_SCHEMA, > }; > > const_regex! { > @@ -262,6 +263,14 @@ pub const GC_CACHE_CAPACITY_SCHEMA: Schema = > schema: GC_CACHE_CAPACITY_SCHEMA, > optional: true, > }, > + "verify-job-verify-threads": { nit: these are user facing and a bit clumsy, especially if to be set via cli. so maybe `default-verificaton-workers`? > + schema: VERIFY_JOB_VERIFY_THREADS_SCHEMA, > + optional: true, > + }, > + "verify-job-read-threads": { ... same: maybe `default-verification-readers`. But no hard opinion here, as at least your suggestions make the correlation to the now pre-existing per verify job configuration parameters clearer. > + schema: VERIFY_JOB_READ_THREADS_SCHEMA, > + optional: true, > + }, > }, > )] > #[derive(Serialize, Deserialize, Default)] > @@ -279,6 +288,10 @@ pub struct DatastoreTuning { > pub gc_atime_cutoff: Option, > #[serde(skip_serializing_if = "Option::is_none")] > pub gc_cache_capacity: Option, > + #[serde(skip_serializing_if = "Option::is_none")] > + pub verify_job_verify_threads: Option, > + #[serde(skip_serializing_if = "Option::is_none")] > + pub verify_job_read_threads: Option, > } > > pub const DATASTORE_TUNING_STRING_SCHEMA: Schema = StringSchema::new("Datastore tuning options") _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel