From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 98A941FF179 for ; Wed, 10 Dec 2025 11:07:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B0FF1736A; Wed, 10 Dec 2025 11:08:39 +0100 (CET) Message-ID: <453a5a70-4df1-4991-92ca-1d662e736ed6@proxmox.com> Date: Wed, 10 Dec 2025 11:08:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , "Max R. Carrara" References: <20251203102217.59923-1-s.rufinatscha@proxmox.com> <20251203102217.59923-6-s.rufinatscha@proxmox.com> Content-Language: en-US From: Samuel Rufinatscha In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.216 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, lib.rs] URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [188.114.96.3] Subject: Re: [pbs-devel] [PATCH proxmox v4 1/4] acme-api: add helper to load client for an account X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 12/9/25 5:51 PM, Max R. Carrara wrote: > On Wed Dec 3, 2025 at 11:22 AM CET, Samuel Rufinatscha wrote: >> The PBS ACME refactoring needs a simple way to obtain an AcmeClient for >> a given configured account without duplicating config wiring. This patch >> adds a load_client_with_account helper in proxmox-acme-api that loads >> the account and constructs a matching client, similarly as PBS previous >> own AcmeClient::load() function. > > Hmm, you say *needs* here, but the function added here isn't actually > used in this series ... > > I personally don't mind keeping this one around for future cases, but > are there any cases among this series (in PBS or otherwise) where we > could've used this function instead already? > > If not, then it's probably not worth keeping it around. I assume you > added it for good reason though, so I suggest to double-check where it's > useful ;) > Good point about this function! :) It was originally introduced to support the minimal client-swap refactor: [PATCH proxmox-backup v4 2/4] acme: drop local AcmeClient. Some of its usages could be removed as part of the API implementation changes in: [PATCH proxmox-backup v4 3/4] acme: change API impls to use proxmox-acme-api handlers. However, it is still required for NodeConfig::acme_client() currently. >> >> Signed-off-by: Samuel Rufinatscha >> --- >> proxmox-acme-api/src/account_api_impl.rs | 5 +++++ >> proxmox-acme-api/src/lib.rs | 3 ++- >> 2 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/proxmox-acme-api/src/account_api_impl.rs b/proxmox-acme-api/src/account_api_impl.rs >> index ef195908..ca8c8655 100644 >> --- a/proxmox-acme-api/src/account_api_impl.rs >> +++ b/proxmox-acme-api/src/account_api_impl.rs >> @@ -116,3 +116,8 @@ pub async fn update_account(name: &AcmeAccountName, contact: Option) -> >> >> Ok(()) >> } >> + >> +pub async fn load_client_with_account(account_name: &AcmeAccountName) -> Result { >> + let account_data = super::account_config::load_account_config(&account_name).await?; >> + Ok(account_data.client()) >> +} >> diff --git a/proxmox-acme-api/src/lib.rs b/proxmox-acme-api/src/lib.rs >> index 623e9e23..96f88ae2 100644 >> --- a/proxmox-acme-api/src/lib.rs >> +++ b/proxmox-acme-api/src/lib.rs >> @@ -31,7 +31,8 @@ mod plugin_config; >> mod account_api_impl; >> #[cfg(feature = "impl")] >> pub use account_api_impl::{ >> - deactivate_account, get_account, get_tos, list_accounts, register_account, update_account, >> + deactivate_account, get_account, get_tos, list_accounts, load_client_with_account, >> + register_account, update_account, >> }; >> >> #[cfg(feature = "impl")] > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel